You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/02 20:36:07 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7338: [AIRFLOW-6714]
Remove magic comments about UTF-8
mik-laj opened a new pull request #7338: [AIRFLOW-6714] Remove magic comments about UTF-8
URL: https://github.com/apache/airflow/pull/7338
# -*- coding: utf-8 -*- is a Python 2 thing. In Python 3+, the default encoding of source files is UTF-8 and that line is useless. In the next PR, I want to introduce automatic checking using pre-commit to avoid regression..
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7338: [AIRFLOW-6714] Remove
magic comments about UTF-8
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7338: [AIRFLOW-6714] Remove magic comments about UTF-8
URL: https://github.com/apache/airflow/pull/7338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7338: [AIRFLOW-6714]
Remove magic comments about UTF-8
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7338: [AIRFLOW-6714] Remove magic comments about UTF-8
URL: https://github.com/apache/airflow/pull/7338#issuecomment-581177908
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=h1) Report
> Merging [#7338](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cf141506a25dbba279b85500d781f7e056540721?src=pr&el=desc) will **increase** coverage by `52.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7338 +/- ##
===========================================
+ Coverage 32.86% 85.82% +52.96%
===========================================
Files 867 867
Lines 40560 40560
===========================================
+ Hits 13331 34812 +21481
+ Misses 27229 5748 -21481
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `100% <ø> (+100%)` | :arrow_up: |
| [...rflow/contrib/hooks/gcp\_video\_intelligence\_hook.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF92aWRlb19pbnRlbGxpZ2VuY2VfaG9vay5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
| [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
| [...irflow/example\_dags/example\_kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9rdWJlcm5ldGVzX2V4ZWN1dG9yLnB5) | `85% <ø> (ø)` | :arrow_up: |
| [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <ø> (ø)` | :arrow_up: |
| [airflow/contrib/utils/weekday.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL3dlZWtkYXkucHk=) | `100% <ø> (+25%)` | :arrow_up: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `100% <ø> (+100%)` | :arrow_up: |
| [airflow/contrib/hooks/qubole\_hook.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3F1Ym9sZV9ob29rLnB5) | `100% <ø> (+100%)` | :arrow_up: |
| [airflow/contrib/sensors/qubole\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcXVib2xlX3NlbnNvci5weQ==) | `100% <ø> (+100%)` | :arrow_up: |
| [airflow/contrib/utils/gcp\_field\_sanitizer.py](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL2djcF9maWVsZF9zYW5pdGl6ZXIucHk=) | `0% <ø> (ø)` | :arrow_up: |
| ... and [1067 more](https://codecov.io/gh/apache/airflow/pull/7338/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=footer). Last update [cf14150...87d54c9](https://codecov.io/gh/apache/airflow/pull/7338?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services