You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2023/04/17 15:22:29 UTC

[GitHub] [airflow] vincbeck commented on a diff in pull request #30682: Introduce consistency of package sequence for "Other" test type

vincbeck commented on code in PR #30682:
URL: https://github.com/apache/airflow/pull/30682#discussion_r1168892655


##########
Dockerfile.ci:
##########
@@ -954,7 +954,7 @@ declare -a SELECTED_TESTS CLI_TESTS API_TESTS PROVIDERS_TESTS CORE_TESTS WWW_TES
 
 function find_all_other_tests() {
     local all_tests_dirs
-    all_tests_dirs=$(find "tests" -type d ! -name '__pycache__')
+    all_tests_dirs=$(find "tests" -type d ! -name '__pycache__' | sort)

Review Comment:
   nit: Would a comment be worth it to explain why we  sort the list of dirs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org