You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/03/07 00:56:11 UTC

[GitHub] [geode] kirklund opened pull request #3274: GEODE-6295: Add Micrometer-based metrics system DO NOT REVIEW

DO NOT REVIEW

- Pass MeterRegistry to GemFireCacheImpl and add getMeterRegistry.
- Load and start MetricsPublishingServices

GEODE-6295: Fixup session upgradeTests

- Add micrometer dependency to explicit list in TomcatInstall.java
  in geode-assembly/geode-assembly-test.

GEODE-6295: Add Micrometer-based metrics system

- Added MetricsSession interface that represents the lifecycle of a
  meter registry, and allows connecting "downstream" registries.
- Added MemberMetricsSession class that creates and configures the meter
  registry for a particular member, and manages connections to the meter
  registry.
- Added methods to InternalDistributedSystem to retrieve both the meter
  registry and the metrics session.
- Added ConnectionConfig interface that extends DistributionConfig, and
  ConnectionConfigImpl that extends DistributionConfigImpl. See below for
  details and rationale.

Constructing a MemberMetricsSession requires a member name and a
distributed system ID. These values were previously available only via a
DistributionConfigImpl constructed by InternalDistributedSystem, based
on properties passed to the InternalDistributedSystem constructor,
supplemented by default values supplied by DistributionConfigImpl. This
made it impossible to inject an already-constructed MemberMetricsSession
into InternalDistributedSystem.

Constructing a DistributionConfigImpl outside of the
InternalDistributedSystem constructor was complicated by several
factors:
- DistributionConfigImpl throws an exception if passed a property that
  it does not recognize.
- Some calls to InternalDistributedSystem.newInstance() pass special
  properties intended for use only in the InternalDistributedSystem
  constructor. DistributionConfigImpl does not recognize these special
  properties.
- The responsibility for extracting and retaining those properties was
  implemented in the InternalDistributedSystem constructor.

We moved the responsibility to extract those special properties from
InternalDistributionConfig to the new ConnectionConfigImpl class.
ConnectionConfigImpl extracts and retains the properties before passing
the properties to its DistributionConfigImpl superclass. The resulting
ConnectionConfigImpl object is a valid DistributionConfigImpl, and also
supplies the special properties needed by the InternalDistributedSystem
constructor.

Given these changes, we now:
- Construct a ConnectionConfigImpl outside of the
  InternalDistributedSystem constructor
- Use the ConnectionConfig to create the MemberMetricsSession
- Inject both the ConnectionConfigImpl and the MemberMetricsSession into
  the InternalDistributedSystem constructor.

Co-Authored-By: Dale Emery <de...@pivotal.io>
Co-Authored-By: Michael Oleske <mo...@pivotal.io>
Co-Authored-By: Mark Hanson <mh...@pivotal.io>
Co-Authored-By: Kirk Lund <kl...@apache.org>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3274 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #3274: GEODE-6295: Add Micrometer-based metrics system DO NOT REVIEW

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
This should be 1.1.3 (which may or may not change the versions of HdrHistogram and LatencyUtils).

[ Full content available at: https://github.com/apache/geode/pull/3274 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #3274: GEODE-6295: Add Micrometer-based metrics system DO NOT REVIEW

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
Possibly could do `CacheMetricsSession.builder()::build` (though that syntax may scare people).

[ Full content available at: https://github.com/apache/geode/pull/3274 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #3274: GEODE-6295: Add Micrometer-based metrics system DO NOT REVIEW

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
We also need a "host name" common tag. That's in the story, but I neglected to bring it up while we were pairing. My bad.

[ Full content available at: https://github.com/apache/geode/pull/3274 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3274: GEODE-6295: Add Micrometer-based metrics system DO NOT REVIEW

Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/3274 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal commented on pull request #3274: GEODE-6295: Add Micrometer-based metrics system DO NOT REVIEW

Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
We will want some documentation for this interface (how to install one, when it's called, etc), given that it's the main way Geode devs will connect downstream registries.

[ Full content available at: https://github.com/apache/geode/pull/3274 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org