You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/26 12:15:30 UTC

[GitHub] [flink] fpompermaier opened a new pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

fpompermaier opened a new pull request #11914:
URL: https://github.com/apache/flink/pull/11914


   ## What is the purpose of the change
   
   Fix error when handling numeric field types with precision 0, such as:
   
   ```sql
   CREATE TABLE orders(
       ord_no integer PRIMARY KEY,
       ord_date date,
       item_name character(35),
       item_grade character(1),
       ord_qty numeric,
       ord_amount numeric,
       CONSTRAINT unq_ordno_itname UNIQUE(ord_qty,ord_amount)
   );
   ```
   
   This address the same problem of SPARK-26538 (https://github.com/apache/spark/pull/23456), using the same fix.
   
   ## Brief change log
   
   In the PostgresCatalog.fromJDBCType, handle Decimal and Numeric types as follow:
   
   ```java
   if (precision > 0) {
   	return DataTypes.DECIMAL(precision, metadata.getScale(colIndex));
   }
   return DataTypes.DECIMAL(DecimalType.MAX_PRECISION, 18);
   ```
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *PostgresCatalogITCase*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  **no**
     - The serializers:  **no**
     - The runtime per-record code paths (performance sensitive):  **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper:  **no**
     - The S3 file system connector:  **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  **no**
     - If yes, how is the feature documented? not documented
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bowenli86 commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619619104


   LGTM, except that can you also add array tests in PostgresCatalogITCase#testArrayTypes()?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 174b4dbf50719f2a8a215be245bbd469acc3b3d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "624422968",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "624422968",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "624422968",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bowenli86 commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-624804332


   LGTM.
   
   BTW, next time, please remember to write jira number and tags in the commit message, e.g. "[FLINK-17385][jdbc][postgres]"
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   * 174b4dbf50719f2a8a215be245bbd469acc3b3d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619540634


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5246f29f20f57b6805dcac293f9024344edf5160 (Sun Apr 26 12:18:02 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] fpompermaier commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
fpompermaier commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-621281628


   @bowenli86 I'll add it within tomorrow hopefully


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   * 174b4dbf50719f2a8a215be245bbd469acc3b3d5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] fpompermaier commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
fpompermaier commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-623310124


   @flinkbot run travis 
   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "623310124",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619573882


   cc @bowenli86 , would you like to review this? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bowenli86 commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-624422968


   @flinkbot run travis


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508",
       "triggerID" : "174b4dbf50719f2a8a215be245bbd469acc3b3d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 174b4dbf50719f2a8a215be245bbd469acc3b3d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=508) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11914:
URL: https://github.com/apache/flink/pull/11914#issuecomment-619541487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/162067327",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268",
       "triggerID" : "5246f29f20f57b6805dcac293f9024344edf5160",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5246f29f20f57b6805dcac293f9024344edf5160 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162067327) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=268) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org