You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by foxish <gi...@git.apache.org> on 2018/01/13 03:12:34 UTC
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
GitHub user foxish opened a pull request:
https://github.com/apache/spark/pull/20256
[SPARK-23063][K8S] K8s changes for publishing scripts (and a couple of other misses)
## What changes were proposed in this pull request?
Including the `-Pkubernetes` flag in a few places it was missed.
## How was this patch tested?
checkstyle, mima through manual tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/foxish/spark SPARK-23063
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20256
----
commit 801f3ec8f68cf2fb6c7f760590be68d83e8d3005
Author: foxish <ra...@...>
Date: 2018-01-13T03:09:59Z
Changes to publishing scripts (and a few other misses)
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #4046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4046/testReport)** for PR 20256 at commit [`b0a2ead`](https://github.com/apache/spark/commit/b0a2ead5935408370a5303fc8f7315357314aeca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86077/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #4046 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4046/testReport)** for PR 20256 at commit [`b0a2ead`](https://github.com/apache/spark/commit/b0a2ead5935408370a5303fc8f7315357314aeca).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
Posted by foxish <gi...@git.apache.org>.
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/20256#discussion_r161365711
--- Diff: dev/create-release/releaseutils.py ---
@@ -185,6 +185,7 @@ def get_commits(tag):
"graphx": "GraphX",
"input/output": CORE_COMPONENT,
"java api": "Java API",
+ "kubernetes": "Kubernetes",
--- End diff --
Can we supply a list/tuple there? I've updated it to `K8S`, but sometimes folks have written `k8s` or `kubernetes` in the PR titles by the looks of it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86076/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86086/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86084/testReport)** for PR 20256 at commit [`73fb21e`](https://github.com/apache/spark/commit/73fb21e4e6fc12bd9d77b98ade8b2ed011b8d68f).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20256#discussion_r161366220
--- Diff: dev/create-release/releaseutils.py ---
@@ -185,6 +185,7 @@ def get_commits(tag):
"graphx": "GraphX",
"input/output": CORE_COMPONENT,
"java api": "Java API",
+ "kubernetes": "Kubernetes",
--- End diff --
so looks like this is for both commit title and JIRA component field... which isn't quite perfect (for example, not R here)
but in any case, multiple left value can map to the same right value, it looks like
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20256
thanks! merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86086/testReport)** for PR 20256 at commit [`b0a2ead`](https://github.com/apache/spark/commit/b0a2ead5935408370a5303fc8f7315357314aeca).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20256#discussion_r161366655
--- Diff: dev/create-release/releaseutils.py ---
@@ -185,6 +185,7 @@ def get_commits(tag):
"graphx": "GraphX",
"input/output": CORE_COMPONENT,
"java api": "Java API",
+ "kubernetes": "Kubernetes",
--- End diff --
yes, I think this looks right
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20256#discussion_r161365293
--- Diff: dev/create-release/releaseutils.py ---
@@ -185,6 +185,7 @@ def get_commits(tag):
"graphx": "GraphX",
"input/output": CORE_COMPONENT,
"java api": "Java API",
+ "kubernetes": "Kubernetes",
--- End diff --
this is for the PR title [foo] - I think [k8s] is more widely used, maybe both
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by foxish <gi...@git.apache.org>.
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/20256
cc/ @felixcheung @sameeragarwal @vanzin @rxin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by sameeragarwal <gi...@git.apache.org>.
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/20256
verified changes to the release scripts and a did simple grep check -- both LGTM. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86076/testReport)** for PR 20256 at commit [`801f3ec`](https://github.com/apache/spark/commit/801f3ec8f68cf2fb6c7f760590be68d83e8d3005).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86076/testReport)** for PR 20256 at commit [`801f3ec`](https://github.com/apache/spark/commit/801f3ec8f68cf2fb6c7f760590be68d83e8d3005).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20256
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20256: [SPARK-23063][K8S] K8s changes for publishing scr...
Posted by foxish <gi...@git.apache.org>.
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/20256#discussion_r161366632
--- Diff: dev/create-release/releaseutils.py ---
@@ -185,6 +185,7 @@ def get_commits(tag):
"graphx": "GraphX",
"input/output": CORE_COMPONENT,
"java api": "Java API",
+ "kubernetes": "Kubernetes",
--- End diff --
Ah, okay, I misread that previously - updated the mapping, and it looks like the script turns things to lower case anyway, so `k8s` and `kubernetes` ought to cover everything. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86077/testReport)** for PR 20256 at commit [`df6f49d`](https://github.com/apache/spark/commit/df6f49d8d04da9ff8113929802a3c674c572e9f5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by foxish <gi...@git.apache.org>.
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/20256
Can someone trigger a retest please?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86084/testReport)** for PR 20256 at commit [`73fb21e`](https://github.com/apache/spark/commit/73fb21e4e6fc12bd9d77b98ade8b2ed011b8d68f).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86077/testReport)** for PR 20256 at commit [`df6f49d`](https://github.com/apache/spark/commit/df6f49d8d04da9ff8113929802a3c674c572e9f5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20256
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86084/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20256: [SPARK-23063][K8S] K8s changes for publishing scripts (a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20256
**[Test build #86086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86086/testReport)** for PR 20256 at commit [`b0a2ead`](https://github.com/apache/spark/commit/b0a2ead5935408370a5303fc8f7315357314aeca).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org