You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Oleg Bonar (Jira)" <ji...@apache.org> on 2019/12/20 12:45:00 UTC
[jira] [Commented] (HIVE-22665) Review and clean unused
'cloningPlan' flag in SerializationUtilities
[ https://issues.apache.org/jira/browse/HIVE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000867#comment-17000867 ]
Oleg Bonar commented on HIVE-22665:
-----------------------------------
Hi [~abstractdog]. I can eliminate this flag.
> Review and clean unused 'cloningPlan' flag in SerializationUtilities
> --------------------------------------------------------------------
>
> Key: HIVE-22665
> URL: https://issues.apache.org/jira/browse/HIVE-22665
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> what's the point of cloningPlan? maybe it's a historical thing
> https://github.com/apache/hive/blob/5a03a6056648eda68ec975843707e05d3ad51fb0/ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java#L642-L646
> https://github.com/apache/hive/blob/5a03a6056648eda68ec975843707e05d3ad51fb0/ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java#L682-L685
> {code}
> if (cloningPlan) {
> plan = deserializeObjectByKryo(kryo, in, planClass);
> } else {
> plan = deserializeObjectByKryo(kryo, in, planClass);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)