You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/10/28 21:48:59 UTC
[jira] Created: (ZOOKEEPER-565) Revisit some java client log
messages
Revisit some java client log messages
-------------------------------------
Key: ZOOKEEPER-565
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
Project: Zookeeper
Issue Type: Improvement
Affects Versions: 3.2.1
Reporter: Jean-Daniel Cryans
As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
{code}
2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
java.io.IOException: Session Expired
at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
{code}
Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-565) Revisit some java client log
messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-565:
-----------------------------------
Fix Version/s: 3.3.0
Assignee: Patrick Hunt
> Revisit some java client log messages
> -------------------------------------
>
> Key: ZOOKEEPER-565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Jean-Daniel Cryans
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
>
> As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
> {code}
> 2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
> java.io.IOException: Session Expired
> at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
> at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
> {code}
> Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-565) Revisit some java client log
messages
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771764#action_12771764 ]
Jean-Daniel Cryans commented on ZOOKEEPER-565:
----------------------------------------------
+1 that's excellent.
> Revisit some java client log messages
> -------------------------------------
>
> Key: ZOOKEEPER-565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Jean-Daniel Cryans
>
> As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
> {code}
> 2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
> java.io.IOException: Session Expired
> at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
> at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
> {code}
> Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-565) Revisit some java client log
messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt resolved ZOOKEEPER-565.
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Fixed as part of ZOOKEEPER-558
> Revisit some java client log messages
> -------------------------------------
>
> Key: ZOOKEEPER-565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Jean-Daniel Cryans
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
>
> As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
> {code}
> 2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
> java.io.IOException: Session Expired
> at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
> at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
> {code}
> Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-565) Revisit some java client log
messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771663#action_12771663 ]
Patrick Hunt commented on ZOOKEEPER-565:
----------------------------------------
Hm, I want to make sure I understand your issues. There is only one session here - the zk client session. there's also a network connection (the socket) btw client/server.
this message is (should be) saying that the zk client lib attempted to re-connect to the server but the client's ZK session has already expired on the server (timeout exceeded, ephemerals cleaned up, etc...) and the ZK session is no longer valid (ie the client needs to create a new session)
I'm happy to make this better (can't be much worse) but I want to make sure I grok your request.
If this log message said something like
2009-10-29 14:25:54,023 - INFO ClientCnxn - Unable to reconnect to ZooKeeper service, session 0x124a265d8b20001 has expired
would that be better? (notice info level since it's not really an error condition.)
your client watcher code is getting (in both cases) the watcher event that notifies it of the session expiration, this is a log by the client library code capturing the event.
better? suggestions?
> Revisit some java client log messages
> -------------------------------------
>
> Key: ZOOKEEPER-565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Jean-Daniel Cryans
>
> As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
> {code}
> 2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
> java.io.IOException: Session Expired
> at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
> at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
> {code}
> Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-565) Revisit some java client log
messages
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771763#action_12771763 ]
Patrick Hunt commented on ZOOKEEPER-565:
----------------------------------------
currently I have changed it to this
2009-10-29 19:53:27,788 - INFO - Client session timed out, have not heard from server in 20001ms for sessionid 0x124a391a9620001, closing socket connection and attempting reconnect
as part of a patch that I'm working on that will attempt to improve the client/server session establishment messages
> Revisit some java client log messages
> -------------------------------------
>
> Key: ZOOKEEPER-565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Jean-Daniel Cryans
>
> As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
> {code}
> 2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
> java.io.IOException: Session Expired
> at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
> at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
> {code}
> Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-565) Revisit some java client log
messages
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771692#action_12771692 ]
Jean-Daniel Cryans commented on ZOOKEEPER-565:
----------------------------------------------
+1 I like the INFO level and better message.
I guess something like this would show a different message?
{noformat}
09/10/16 15:14:02 WARN zookeeper.ClientCnxn: Exception closing session 0x1245f6866060002 to sun.nio.ch.SelectionKeyImpl@12efcfe
java.io.IOException: TIMED OUT
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:906)
{noformat}
> Revisit some java client log messages
> -------------------------------------
>
> Key: ZOOKEEPER-565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-565
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Jean-Daniel Cryans
>
> As discussed during the 10/23 meeting, some messages in the java client logs are mixing up terms from different levels. For example:
> {code}
> 2009-10-14 15:12:43,566 WARN org.apache.zookeeper.ClientCnxn: Exception closing session 0x1244f619478000d to sun.nio.ch.SelectionKeyImpl@15e32c4
> java.io.IOException: Session Expired
> at org.apache.zookeeper.ClientCnxn$SendThread.readConnectResult(ClientCnxn.java:589)
> at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:709)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:945)
> {code}
> Which session are we talking about in the first line? Now I know that it's a network-related session and not the ZK one, but I've seen many of our users getting confused over those lines.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.