You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Nate McCall (Created) (JIRA)" <ji...@apache.org> on 2011/10/01 00:13:45 UTC
[jira] [Created] (CASSANDRA-3288) CfDef can default to an invalid
id and fail during system_add_column_family
CfDef can default to an invalid id and fail during system_add_column_family
---------------------------------------------------------------------------
Key: CASSANDRA-3288
URL: https://issues.apache.org/jira/browse/CASSANDRA-3288
Project: Cassandra
Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Nate McCall
Priority: Critical
The line from this commit:
https://github.com/apache/cassandra/commit/38e3e85b121ba6308ba3ceb26312d12ed0d609ec#L1R683
Introduced an issue in that some clients, particularly Hector, will send a CfDef with an ID having been set to 0. Done via the CfDef#setId, the isSetId bit is flipped to true, causing error if schemaId of 0 already exists, which given the use case, is likely.
Since we know the context of a system_create_column_family, this can be sidestepped by just stepping on whatever ID is there (irrelevant on a create anyway) with the value returned from: Schema.instance.nextCFId()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3288) CfDef can default to an invalid
id and fail during system_add_column_family
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3288:
--------------------------------------
Reviewer: zznate
Component/s: API
Fix Version/s: 1.0.0
Assignee: Jonathan Ellis
> CfDef can default to an invalid id and fail during system_add_column_family
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3288
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0
> Reporter: Nate McCall
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 1.0.0
>
> Attachments: 3288.txt
>
>
> The line from this commit:
> https://github.com/apache/cassandra/commit/38e3e85b121ba6308ba3ceb26312d12ed0d609ec#L1R683
> Introduced an issue in that some clients, particularly Hector, will send a CfDef with an ID having been set to 0. Done via the CfDef#setId, the isSetId bit is flipped to true, causing error if schemaId of 0 already exists, which given the use case, is likely.
> Since we know the context of a system_create_column_family, this can be sidestepped by just stepping on whatever ID is there (irrelevant on a create anyway) with the value returned from: Schema.instance.nextCFId()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3288) CfDef can default to an invalid
id and fail during system_add_column_family
Posted by "Nate McCall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate McCall updated CASSANDRA-3288:
-----------------------------------
Attachment: 3822v2.txt
v2 adds same ignore for system_add_keyspace
> CfDef can default to an invalid id and fail during system_add_column_family
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3288
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0
> Reporter: Nate McCall
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 1.0.0
>
> Attachments: 3288.txt, 3822v2.txt
>
>
> The line from this commit:
> https://github.com/apache/cassandra/commit/38e3e85b121ba6308ba3ceb26312d12ed0d609ec#L1R683
> Introduced an issue in that some clients, particularly Hector, will send a CfDef with an ID having been set to 0. Done via the CfDef#setId, the isSetId bit is flipped to true, causing error if schemaId of 0 already exists, which given the use case, is likely.
> Since we know the context of a system_create_column_family, this can be sidestepped by just stepping on whatever ID is there (irrelevant on a create anyway) with the value returned from: Schema.instance.nextCFId()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3288) CfDef can default to an invalid
id and fail during system_add_column_family
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3288:
--------------------------------------
Attachment: 3288.txt
patch to explicitly ignore client-set ids on create
> CfDef can default to an invalid id and fail during system_add_column_family
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3288
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Nate McCall
> Priority: Critical
> Attachments: 3288.txt
>
>
> The line from this commit:
> https://github.com/apache/cassandra/commit/38e3e85b121ba6308ba3ceb26312d12ed0d609ec#L1R683
> Introduced an issue in that some clients, particularly Hector, will send a CfDef with an ID having been set to 0. Done via the CfDef#setId, the isSetId bit is flipped to true, causing error if schemaId of 0 already exists, which given the use case, is likely.
> Since we know the context of a system_create_column_family, this can be sidestepped by just stepping on whatever ID is there (irrelevant on a create anyway) with the value returned from: Schema.instance.nextCFId()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3288) CfDef can default to an invalid
id and fail during system_add_column_family
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118512#comment-13118512 ]
Jonathan Ellis commented on CASSANDRA-3288:
-------------------------------------------
first reported on http://www.mail-archive.com/user@cassandra.apache.org/msg17649.html
> CfDef can default to an invalid id and fail during system_add_column_family
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3288
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0
> Reporter: Nate McCall
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 1.0.0
>
> Attachments: 3288.txt
>
>
> The line from this commit:
> https://github.com/apache/cassandra/commit/38e3e85b121ba6308ba3ceb26312d12ed0d609ec#L1R683
> Introduced an issue in that some clients, particularly Hector, will send a CfDef with an ID having been set to 0. Done via the CfDef#setId, the isSetId bit is flipped to true, causing error if schemaId of 0 already exists, which given the use case, is likely.
> Since we know the context of a system_create_column_family, this can be sidestepped by just stepping on whatever ID is there (irrelevant on a create anyway) with the value returned from: Schema.instance.nextCFId()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3288) CfDef can default to an invalid
id and fail during system_add_column_family
Posted by "Jonathan Ellis (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-3288.
---------------------------------------
Resolution: Fixed
committed v2
> CfDef can default to an invalid id and fail during system_add_column_family
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-3288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3288
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0
> Reporter: Nate McCall
> Assignee: Jonathan Ellis
> Priority: Critical
> Fix For: 1.0.0
>
> Attachments: 3288.txt, 3822v2.txt
>
>
> The line from this commit:
> https://github.com/apache/cassandra/commit/38e3e85b121ba6308ba3ceb26312d12ed0d609ec#L1R683
> Introduced an issue in that some clients, particularly Hector, will send a CfDef with an ID having been set to 0. Done via the CfDef#setId, the isSetId bit is flipped to true, causing error if schemaId of 0 already exists, which given the use case, is likely.
> Since we know the context of a system_create_column_family, this can be sidestepped by just stepping on whatever ID is there (irrelevant on a create anyway) with the value returned from: Schema.instance.nextCFId()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira