You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/07/26 08:37:04 UTC

[GitHub] [mynewt-core] kasjer commented on pull request #2644: hw/bus/spi_hal: Fix bus_spi_write_read

kasjer commented on pull request #2644:
URL: https://github.com/apache/mynewt-core/pull/2644#issuecomment-886498470


   > To be consistent with:
   > 
   > https://github.com/apache/mynewt-core/blob/ca3280bcd39b1dc44df307db27f243c9a3b39ab7/hw/bus/drivers/spi_hal/src/spi_hal.c#L145
   > 
   > the memset should probably be setting it to 0xFF instead of 0?
   
   @ncasaril thanks for pointing out inconsistency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org