You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/12/28 12:26:48 UTC
[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/3033
[CARBONDATA-3215] Optimize the documentation
When user use the Global dictionary, local dictionary，non-dictionary in the code, users maybe have some confusion. The same for mvdataMap and IndexDataMap. I describe and list it in this PR.
1. describe Global dictionary, local dictionary，non-dictionary together in doc
2. list mvdataMap and IndexDataMap
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
yes, only update the doc
- [ ] Testing done
No need
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-3215_OptimizeDoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3033.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3033
----
commit 1eae260dcbddadb592357e0f71309d27960de6c0
Author: xubo245 <xu...@...>
Date: 2018-12-28T12:23:13Z
[CARBONDATA-3215] Optimize the documentation
1. describe Global dictionary local dictionary，non-dictionary together in doc
2. list mvdataMap and IndexDataMap
----
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2079/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10333/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3033
retest this please
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2068/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2262/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2273/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3033
retest this please
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2214/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2475/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10469/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3033
@sraghunandan please review it.
---
[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3033#discussion_r244475523
--- Diff: docs/datamap-developer-guide.md ---
@@ -3,15 +3,15 @@
### Introduction
DataMap is a data structure that can be used to accelerate certain query of the table. Different DataMap can be implemented by developers.
Currently, there are two 2 types of DataMap supported:
--- End diff --
done, thanks
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10514/
---
[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3033#discussion_r247000712
--- Diff: docs/datamap-developer-guide.md ---
@@ -19,16 +19,16 @@
### Introduction
DataMap is a data structure that can be used to accelerate certain query of the table. Different DataMap can be implemented by developers.
-Currently, there are two 2 types of DataMap supported:
-1. IndexDataMap: DataMap that leverages index to accelerate filter query
-2. MVDataMap: DataMap that leverages Materialized View to accelerate OLAP style query, like SPJG query (select, predicate, join, groupby)
+Currently, there are two types of DataMap supported:
+1. IndexDataMap: DataMap that leverages index to accelerate filter query, including Lucene DataMap and BloomFilter DataMap.
--- End diff --
I feel it is better to use "....acclerate filter query. Lucene DataMap and BloomFiler DataMap belongs to this type of DataMaps"
similar to MV
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10322/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2284/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2256/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10520/
---
[GitHub] carbondata pull request #3033: [CARBONDATA-3215] Optimize the documentation
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3033#discussion_r244441456
--- Diff: docs/datamap-developer-guide.md ---
@@ -3,15 +3,15 @@
### Introduction
DataMap is a data structure that can be used to accelerate certain query of the table. Different DataMap can be implemented by developers.
Currently, there are two 2 types of DataMap supported:
--- End diff --
```suggestion
Currently, there are two types of DataMap supported:
```
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2432/
---
[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2481/
---