DO NOT REPLY [Bug 17876] New: - Session cache (SHMHT) loses SSL Sessions

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17876>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17876

Session cache  (SHMHT) loses SSL Sessions

           Summary: Session cache  (SHMHT) loses SSL Sessions
           Product: Apache httpd-2.0
           Version: 2.0.44
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: mod_ssl
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: andreasl67@yahoo.de


table_insert_kd() fails if the bucket list contains exactly one entry.

The bug causes this bucket content's to be overwritten, even if
keys do not match.

Offending code from ssl_util_table.c:1171, table_insert_kd()

    last_p = NULL;
    for (entry_p = table_p->ta_buckets[bucket];
         (entry_p != NULL) && (entry_p->te_next_p != last_p);
         last_p = entry_p, entry_p = entry_p->te_next_p) {
        if (entry_p->te_key_size == ksize
            && memcmp(ENTRY_KEY_BUF(entry_p), key_buf, ksize) == 0)
            break;
    }


Possible Fixes:

 - Remove "&& (entry_p->te_next_p != last_p)" from loop condition
 - Replace fragment above by
     "&& (entry_p->te_next_p != last_p || last_p != NULL)"
   AND rewrite code at 1180, more changed may be neccessary
      if (entry_p != NULL) {

PS: I found this bug because I'm using util_table for other purposes

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org