You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Juanjo Marron <jm...@us.ibm.com> on 2015/09/24 00:47:01 UTC

Review Request 38696: AMBARI-12813 Increase OS kernel parameters for hbase

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38696/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.


Bugs: AMBARI-12813
    https://issues.apache.org/jira/browse/AMBARI-12813


Repository: ambari


Description
-------

Ambari recipes generate /etc/security/limits.d/[service].conf to limit the open file, and number of processes for each user. It appears that hbase service is not doing this while hdfs, hive , ams, yarn, maprdeduce ... are cretaing their own user limits


Diffs
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 242e9a7 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 991f4e7 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f22b035 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py 084ee06 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase.conf.j2 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py ff25933 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py f19da4c 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 2cb05c0 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 0cfc2e3 

Diff: https://reviews.apache.org/r/38696/diff/


Testing
-------

Test included in:
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py

Hadoop QA comment approved the tests:
+1 core tests. The patch passed unit tests in ambari-server.


Thanks,

Juanjo  Marron


Re: Review Request 38696: AMBARI-12813 Increase OS kernel parameters for hbase

Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38696/#review101122
-----------------------------------------------------------

Ship it!


Reviewed on: https://reviews.apache.org/r/38895/
It has been shipped

- Juanjo  Marron


On Sept. 23, 2015, 10:47 p.m., Juanjo  Marron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38696/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 10:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.
> 
> 
> Bugs: AMBARI-12813
>     https://issues.apache.org/jira/browse/AMBARI-12813
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari recipes generate /etc/security/limits.d/[service].conf to limit the open file, and number of processes for each user. It appears that hbase service is not doing this while hdfs, hive , ams, yarn, maprdeduce ... are cretaing their own user limits
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml 242e9a7 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 991f4e7 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py f22b035 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py 084ee06 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase.conf.j2 PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py ff25933 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py f19da4c 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 2cb05c0 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 0cfc2e3 
> 
> Diff: https://reviews.apache.org/r/38696/diff/
> 
> 
> Testing
> -------
> 
> Test included in:
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py
> 
> Hadoop QA comment approved the tests:
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>