You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/06 07:27:57 UTC

[GitHub] [spark] tanelk commented on pull request #32057: [SPARK-34961][SQL] Migrate First function from DeclarativeAggregate to TypedImperativeAggregate to improve performance

tanelk commented on pull request #32057:
URL: https://github.com/apache/spark/pull/32057#issuecomment-813893950


   In general `DeclarativeAggregate` should be faster than `ImperativeAggregate`. Based on [this](https://github.com/apache/spark/pull/10786/files#r50038294) benchmark the `CentralMomentAgg` was migrated from imperative to declarative. So I assume, that for primitive types the `first` would become slower because of this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org