You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2016/08/31 19:09:02 UTC

kafka git commit: MINOR: onCompletion: metadata valid only if no exception

Repository: kafka
Updated Branches:
  refs/heads/trunk 2e731a9ee -> bc397db0e


MINOR: onCompletion: metadata valid only if no exception

Modifies example in doc change

Author: ybyzek <yb...@users.noreply.github.com>

Reviewers: Guozhang Wang, Ismael Juma

Closes #1805 from ybyzek/onComplete_doc


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/bc397db0
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/bc397db0
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/bc397db0

Branch: refs/heads/trunk
Commit: bc397db0e13998160f0b4e723211d6662ca7e964
Parents: 2e731a9
Author: ybyzek <yb...@users.noreply.github.com>
Authored: Wed Aug 31 12:08:59 2016 -0700
Committer: Guozhang Wang <wa...@gmail.com>
Committed: Wed Aug 31 12:08:59 2016 -0700

----------------------------------------------------------------------
 .../org/apache/kafka/clients/producer/KafkaProducer.java     | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/bc397db0/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
index 05d9377..fbc1099 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
@@ -391,9 +391,11 @@ public class KafkaProducer<K, V> implements Producer<K, V> {
      * producer.send(myRecord,
      *               new Callback() {
      *                   public void onCompletion(RecordMetadata metadata, Exception e) {
-     *                       if(e != null)
-     *                           e.printStackTrace();
-     *                       System.out.println("The offset of the record we just sent is: " + metadata.offset());
+     *                       if(e != null) {
+     *                          e.printStackTrace();
+     *                       } else {
+     *                          System.out.println("The offset of the record we just sent is: " + metadata.offset());
+     *                       }
      *                   }
      *               });
      * }