You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by Eiliries <gi...@git.apache.org> on 2017/01/09 00:55:01 UTC
[GitHub] incubator-fineract pull request #273: Added recurringFrequency to recurringD...
GitHub user Eiliries opened a pull request:
https://github.com/apache/incubator-fineract/pull/273
Added recurringFrequency to recurringDeposit files.
This is the back-end part of the fix for https://github.com/openMF/community-app/issues/1682. The API docs have also been updated as the recurring deposit product now also uses recurringFrequency instead of recurringDepositFrequency for internal consistency.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Eiliries/incubator-fineract depositevery
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit 9c4b41228dfd15742d936cc3d7ed7e9d2d2e41f3
Author: Tan Gemicioglu <ta...@hotmail.com>
Date: 2017-01-09T00:37:36Z
Added recurringFrequency to all relevant recurringDeposit account and product files.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #273: Added recurringFrequency to recurringDeposit ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/273
Changes looks OK. Basically you are capturing recurringFrequencyType
recurringFrequency data. But what is the use of these values?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #273: Added recurringFrequency to recurringDeposit ...
Posted by Eiliries <gi...@git.apache.org>.
Github user Eiliries commented on the issue:
https://github.com/apache/incubator-fineract/pull/273
For this PR, I just made them stored in the product and account so that they can be used. I think it should have an effect on the interest chart but I'm not sure how (especially considering there is a depositPeriodFrequency variable as well). The documentation specifies that these values should have been captured anyways, but they weren't working properly for a while.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---