[GitHub] [samza] prateekm commented on a change in pull request #1489: SAMZA-2591: Async Commit [1/3]: Checkpoint v2 migration

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1489:
URL: https://github.com/apache/samza/pull/1489#discussion_r616965346



##########
File path: samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointId.java
##########
@@ -61,6 +61,11 @@ public long getNanos() {
     return nanos;
   }
 
+  /**
+   * WARNING: Do not change the toString() representation. It is used for serde'ing {@link CheckpointId} as part of task
+   * checkpoints, in conjunction with {@link #fromString(String)}.
+   * @return the String representation of this {@link CheckpointId}.
+   */

Review comment:
       @mynameborat It didn't seem like it was worth adding the overhead of a separate serde class with the associated ceremony (serde factory, classload serde depending on the class version, etc.) for a relatively simple operation. The interface also isn't exactly the same (since this serdes to/from string while the Serde interfaces use byte[]). 
   
   It makes sense to rename them to 'to/from' or 'serialize/deserialize'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org