You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/11/14 21:31:19 UTC
DO NOT REPLY [Bug 50268] New: PATCH: Adds static and dynamic
destinations to JMSProducer
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
Summary: PATCH: Adds static and dynamic destinations to
JMSProducer
Product: JMeter
Version: unspecified
Platform: All
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P2
Component: Main
AssignedTo: notifications@jakarta.apache.org
ReportedBy: jbutler@hcn-inc.com
Created an attachment (id=26295)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26295)
patch file
This patch provides the ability for JMSProducer to change destinations while
the test runs so that it works with variables and foreach controllers. The
option to use the current behavior is still preserved.
Adds a check box for static destinations to the JMSProducer sampler gui. If
"Use static destination" is not checked then the destination the producer sends
to will update each time the thread group loops. This way the producer can send
to a different destination each time. If "Use static destination" is checked
then the destination will be fixed the first time the thread group loops which
is the current behavior.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
Milamber <mi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26302|0 |1
is obsolete| |
--- Comment #7 from Milamber <mi...@apache.org> 2010-11-17 13:13:37 EST ---
Created an attachment (id=26306)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26306)
New screenshot
Thanks for your comments.
In this screnshot, I have doing your suggestion
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #5 from Milamber <mi...@apache.org> 2010-11-16 14:20:21 EST ---
Created an attachment (id=26302)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26302)
Screenshot
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #1 from Milamber <mi...@apache.org> 2010-11-14 18:25:33 EST ---
Thanks for your patch. I works too on a JMS patch for dynamic/static publisher
and subscriber. Your approach is different and seems better vs my (futur)
patch. I will try to test and verify your patch the next week.
Milamber
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #2 from Sebb <se...@apache.org> 2010-11-16 05:26:31 EST ---
Looks OK to me as well.
One minor tweak to the patch - when getting/setting the property
USE_STATIC_DEST, the default needs to be "true". Otherwise existing plans will
be treated as dynamic, and saved "static" plans will have an unnecessary
property.
Note to self: need to update component_reference.xml as well.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #4 from Milamber <mi...@apache.org> 2010-11-16 14:19:13 EST ---
OK for comments, sebb.
Currently I works on this patch. I will change some GUI (came from my patch)
for put the option in bottom (see screenshot) (comments on labels/type are
welcome)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #8 from Sebb <se...@apache.org> 2010-11-17 14:10:29 EST ---
Thanks!
Looks good.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] Adds static and dynamic destinations to JMS
Publisher
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
Milamber <mi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #9 from Milamber <mi...@apache.org> 2010-11-17 14:46:11 EST ---
Done. I have tried to preserve API on Publisher.java
URL: http://svn.apache.org/viewvc?rev=1036177&view=rev
Log:
Bug 50268 - Adds static and dynamic destinations to JMS Publisher
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/Publisher.java
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/BaseJMSSampler.java
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java
jakarta/jmeter/trunk/xdocs/changes.xml
jakarta/jmeter/trunk/xdocs/images/screenshots/jmspublisher.png
jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #3 from Sebb <se...@apache.org> 2010-11-16 05:30:12 EST ---
Forgot to add - no need to resubmit the patch - we can easily add the extra
"default" parameter to the get/set Property method calls.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] PATCH: Adds static and dynamic destinations
to JMSProducer
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
--- Comment #6 from Sebb <se...@apache.org> 2010-11-16 14:42:23 EST ---
Sorry, but I don't like the position of the radio buttons so far from the
Destination field.
The dest field does not need to be the full width of the screen, so the
selection field should fit on the same line.
As to the actual text - if it is on the same line, it could be simplified
somewhat; perhaps to:
Destination | | Setup: o At startup o Each sample
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50268] Adds static and dynamic destinations to JMS
Publisher
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50268
Milamber <mi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|PATCH: Adds static and |Adds static and dynamic
|dynamic destinations to |destinations to JMS
|JMSProducer |Publisher
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org