[GitHub] [maven] gnodet commented on a diff in pull request #1228: resolve Circular dependencies for project org.apache.maven:maven-xml-impl and rename name

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #1228:
URL: https://github.com/apache/maven/pull/1228#discussion_r1319832508


##########
maven-xml-impl/pom.xml:
##########
@@ -48,6 +48,12 @@ under the License.
       <artifactId>plexus-xml</artifactId>
       <version>${plexusXmlVersion}</version>
       <scope>provided</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>org.apache.maven</groupId>
+          <artifactId>maven-xml-impl</artifactId>
+        </exclusion>
+      </exclusions>

Review Comment:
   Doesn't the current module take precedence during resolution ?
   What kind of issues does it actually cause ?



##########
maven-xml-impl/pom.xml:
##########
@@ -26,7 +26,7 @@ under the License.
   </parent>
 
   <artifactId>maven-xml-impl</artifactId>
-  <name>Implementation of Maven API XML</name>
+  <name>maven-xml-impl(Implementation of Maven API XML)</name>

Review Comment:
   This is not coherent with the other packages afaik.
   I'd rather do that globally all all modules if we want to go that way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org