[GitHub] [pinot] walterddr commented on pull request #9758: [hotfix] cover non-tested data table v4 code path

[GitBox <gi...@apache.org>]

walterddr commented on PR #9758:
URL: https://github.com/apache/pinot/pull/9758#issuecomment-1307660787

   > Since this is labelled as hotfix, I am wondering if you have started using V4.
   > 
   > AFAIK, it wasn't tested and there was plan to move over to V4 since it also has NULL handling support IIRC. The current / default version is V3.
   
   label as hotfix because this was a regression introduced a bit earlier: 
   - when i decouple the code in #9731 , the DataTableImplV4 becomes a copy of the original BaseDataBlock, but since it is no longer a data block, we dont have the test coverage via the DataBlockTest, and neither was it tested in the DataTableTest b/c it doesn't test V4 (only V3)
   - it is not being used after the decoupling, but it is still good to test the V4 impl. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org