You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/14 00:47:37 UTC
[GitHub] [druid] clintropolis opened a new pull request #9698: fixes for
inline subqueries when multi-value dimension is present
clintropolis opened a new pull request #9698: fixes for inline subqueries when multi-value dimension is present
URL: https://github.com/apache/druid/pull/9698
Fixes #9697.
### Description
Modifies Group By queries to treat unknown column capabilities as potentially multi-value dimensions, and TopN query to use `HeapBasedTopNAlgorithm` when capabilities are unknown to handle strings without known cardinality and numbers.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths.
- [x] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* `GroupByQueryEngineV2`
* `TopNQueryEngine`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #9698:
fixes for inline subqueries when multi-value dimension is present
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #9698: fixes for inline subqueries when multi-value dimension is present
URL: https://github.com/apache/druid/pull/9698#discussion_r410507374
##########
File path: processing/src/main/java/org/apache/druid/query/topn/TopNQueryEngine.java
##########
@@ -132,7 +132,7 @@ private TopNMapFn getMapFn(
topNAlgorithm = new TimeExtractionTopNAlgorithm(adapter, query);
} else if (selector.isHasExtractionFn()) {
topNAlgorithm = new HeapBasedTopNAlgorithm(adapter, query);
- } else if (columnCapabilities != null && !(columnCapabilities.getType() == ValueType.STRING
+ } else if (columnCapabilities == null || !(columnCapabilities.getType() == ValueType.STRING
Review comment:
nit: maybe nice to comment when `columnCapabilities` can be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org