[GitHub] [spark] MaxGekk commented on a change in pull request #34761: [SPARK-37508][SQL] Add CONTAINS() string function

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #34761:
URL: https://github.com/apache/spark/pull/34761#discussion_r761320157



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -465,6 +465,23 @@ abstract class StringPredicate extends BinaryExpression
 /**
  * A function that returns true if the string `left` contains the string `right`.
  */
+@ExpressionDescription(
+  usage = """
+    _FUNC_(expr1, expr2) - Returns a boolean value if expr2 is found inside expr1.

Review comment:
       @AngersZhuuuu I have realised that this comment might confuse users. Could you align it to PR's description in a follow up PR:
   ```
   Returns a BOOLEAN. The value is True if right is found inside left. Returns NULL if either input expression is NULL. Otherwise, returns False.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org