You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/09/16 17:04:36 UTC
[GitHub] [hudi] nsivabalan commented on a change in pull request #2092: [HUDI-1285] Fix merge on read DAG to make docker demo pass
nsivabalan commented on a change in pull request #2092:
URL: https://github.com/apache/hudi/pull/2092#discussion_r489590017
##########
File path: docker/demo/config/test-suite/complex-dag-mor.yaml
##########
@@ -81,11 +81,7 @@ second_hive_query:
query1: "select count(*) from testdb.table1 group by `_row_key` having count(*) > 1"
result1: 0
query2: "select count(*) from testdb.table1"
- result2: 3100
- query3: "select count(*) from testdb.table1_rt group by `_row_key` having count(*) > 1"
- result3: 0
- query4: "select count(*) from testdb.table1_rt"
- result4: 3100
+ result2: 1100
Review comment:
while you are at it, since rollback is not effective, can we remove it from this dag file until we have a fix. I see this dag more as a sanity check dag and so everything should be succeeding.
##########
File path: docker/demo/config/test-suite/complex-dag-mor.yaml
##########
@@ -81,11 +81,7 @@ second_hive_query:
query1: "select count(*) from testdb.table1 group by `_row_key` having count(*) > 1"
result1: 0
query2: "select count(*) from testdb.table1"
- result2: 3100
- query3: "select count(*) from testdb.table1_rt group by `_row_key` having count(*) > 1"
- result3: 0
- query4: "select count(*) from testdb.table1_rt"
- result4: 3100
+ result2: 1100
Review comment:
same for cow dag as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org