[jira] [Commented] (NIFI-4892) ValidateCSV Processor - no doublequote escaping in "invalid" output

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369849#comment-16369849 ] 

ASF GitHub Bot commented on NIFI-4892:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/2481

    NIFI-4892 - ValidateCSV: no doublequote escaping in invalid output

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-4892

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2481.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2481
    
----
commit 3a57674f30dc27eaf83e770814f6fe51d3be8b05
Author: Pierre Villard <pi...@...>
Date:   2018-02-20T09:36:31Z

    NIFI-4892 - ValidateCSV: no doublequote escaping in invalid output

----


> ValidateCSV Processor - no doublequote escaping in "invalid" output
> -------------------------------------------------------------------
>
>                 Key: NIFI-4892
>                 URL: https://issues.apache.org/jira/browse/NIFI-4892
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Eugeny Kolpakov
>            Assignee: Pierre Villard
>            Priority: Major
>         Attachments: ValidateCSV_LineByLine_EscapingBug.xml
>
>
> ValidateCSV processor fails to preserve field escaping for flow files routed to "invalid" relation when "Line by Line" validation strategy is used.
>  
> Minimal sample flow attached.
>  
> Observed in 1.4.0, but 1.5.0 might be affected as well - I'll update this ticket after upgrading to 1.5.0 (unless someone could do that earlier)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)