[jira] [Commented] (TS-2789) Typo in HttpSessionManger would cause ATS reuse wrong session to origin server.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993048#comment-13993048 ] 

ASF subversion and git services commented on TS-2789:
-----------------------------------------------------

Commit ba0c8a9d8652087c1e0316c63b5bb359c906cf2a in trafficserver's branch refs/heads/master from [~Kang Li]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ba0c8a9 ]

TS-2789: Typo in HttpSessionManger would cause ATS reuse wrong session to origin server.


> Typo in HttpSessionManger would cause ATS reuse wrong session to origin server.
> -------------------------------------------------------------------------------
>
>                 Key: TS-2789
>                 URL: https://issues.apache.org/jira/browse/TS-2789
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: kang li
>            Assignee: Bryan Call
>              Labels: yahoo
>             Fix For: 5.0.0
>
>
> There is a typo in HttpSessionManger
> (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) == ats_ip_port_cast(addr))) 
> The fix would be 
> {code}
>     -          (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(addr) == ats_ip_port_cast(addr)))
>     +          (ats_ip_addr_eq(&s->server_ip.sa, addr) && ats_ip_port_cast(&s->server_ip.sa) == ats_ip_port_cast(addr)))
> {code}
> This typo skip the port check, so if requests to same origin server would use one same session even though different port.
>  
> Which would cause ATS-5.0 reuse wrong session to origin. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)