[Bug 51815] Unable to construct record instance

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=51815

--- Comment #7 from Triqui <pe...@gmail.com> ---
You are right. I don't know if POI handles the file stream a bit better now and
this error is not showing anymore or I was wrong when I said the attachment in
bug 50833 had this problem too. Maybe I only tested with BiffViewer and didn't
try to create a workbook the normal way.
But, I would like to know what you think about what I said before about the
comments in the code stating that the information is optional, shouldn't we
avoid throwing exceptions from that piece of code?
Also, in a case like this where a file works with the current version, but the
BiffViewer from that same version throws an exception, what should be done? Fix
BiffViewer? Since BiffViewer uses the same WriteAccessRecord class, how can
this be fixed?
Moreover, do you think it would be possible to write some tests for BiffViewer
in order to validate this bug?
I really think a try-catch block surrounding setUsername() would be a nice
addition, given that in that place the data is already assumed to be corrupted
and poi is just trying its best to reconstruct it. Throwing an exception if
something fails while doing so seems very strange.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org