You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/12 01:32:24 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
rkhachatryan opened a new pull request #16457:
URL: https://github.com/apache/flink/pull/16457
## What is the purpose of the change
Log why job requirements can't be fulfilled (how many TMs and slots are alive).
Motivated by debugging test failures.
This is more of a proposal.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
}, {
"hash" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328",
"triggerID" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"triggerType" : "PUSH"
}, {
"hash" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351",
"triggerID" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"triggerType" : "PUSH"
}, {
"hash" : "43b9f912edc610a59c7a84ee549e5c2ff61b9dd9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20368",
"triggerID" : "43b9f912edc610a59c7a84ee549e5c2ff61b9dd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61bd9db42a4990df50beca81555e1091eb880f2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351)
* 43b9f912edc610a59c7a84ee549e5c2ff61b9dd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20368)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-878102211
@tillrohrmann , @zentol what do you think about this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877907367
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 48113937331f9eaf9da6f16b70e7c86680eef30b (Mon Jul 12 01:35:32 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r667791324
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -647,7 +647,12 @@ private ResourceCounter tryFulfillRequirementsWithPendingSlots(
pendingSlots = allocationResult.getNewAvailableResources();
if (!allocationResult.isSuccessfulAllocating()
&& sendNotEnoughResourceNotifications) {
- LOG.warn("Could not fulfill resource requirements of job {}.", jobId);
+ // TODO (review): free slots are logged as zero here, but non-zero in
+ // JobMaster.slotPoolService
Review comment:
Can we resolve this TODO? I don't really understand what the problem is.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java
##########
@@ -348,14 +348,17 @@ public void notifyNotEnoughResourcesAvailable(
Collection<ResourceRequirement> acquiredResources) {
assertRunningInMainThread();
- failPendingRequests();
+ failPendingRequests(acquiredResources);
}
- private void failPendingRequests() {
+ private void failPendingRequests(Collection<ResourceRequirement> acquiredResources) {
if (!pendingRequests.isEmpty()) {
final NoResourceAvailableException cause =
new NoResourceAvailableException(
- "Could not acquire the minimum required resources.");
+ "Could not acquire the minimum required resources. Acquired: "
+ + acquiredResources
+ + ". Current slot service status: "
Review comment:
```suggestion
+ ". Current slot pool status: "
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java
##########
@@ -306,4 +306,12 @@ public AllocatedSlotReport createAllocatedSlotReport(ResourceID taskManagerId) {
STARTED,
CLOSED,
}
+
+ protected String getSlotServiceStatus() {
+ return String.format(
+ "registered TMs: %d, registered slots: %d free slots: %d",
Review comment:
```suggestion
"Registered TMs: %d, registered slots: %d free slots: %d",
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -647,7 +647,12 @@ private ResourceCounter tryFulfillRequirementsWithPendingSlots(
pendingSlots = allocationResult.getNewAvailableResources();
if (!allocationResult.isSuccessfulAllocating()
&& sendNotEnoughResourceNotifications) {
- LOG.warn("Could not fulfill resource requirements of job {}.", jobId);
+ // TODO (review): free slots are logged as zero here, but non-zero in
+ // JobMaster.slotPoolService
Review comment:
This log statement happens on the `ResourceManager`. The other log statement happens on the `JobMaster`. It could be the case that the RM has assigned all its slots to the JM (e.g. the RM has 0 free slots) but the JM hasn't assigned them yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
}, {
"hash" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328",
"triggerID" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"triggerType" : "PUSH"
}, {
"hash" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351",
"triggerID" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"triggerType" : "PUSH"
}, {
"hash" : "43b9f912edc610a59c7a84ee549e5c2ff61b9dd9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20368",
"triggerID" : "43b9f912edc610a59c7a84ee549e5c2ff61b9dd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43b9f912edc610a59c7a84ee549e5c2ff61b9dd9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20368)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r669357359
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java
##########
@@ -348,14 +348,17 @@ public void notifyNotEnoughResourcesAvailable(
Collection<ResourceRequirement> acquiredResources) {
assertRunningInMainThread();
- failPendingRequests();
+ failPendingRequests(acquiredResources);
}
- private void failPendingRequests() {
+ private void failPendingRequests(Collection<ResourceRequirement> acquiredResources) {
if (!pendingRequests.isEmpty()) {
final NoResourceAvailableException cause =
new NoResourceAvailableException(
- "Could not acquire the minimum required resources.");
+ "Could not acquire the minimum required resources. Acquired: "
+ + acquiredResources
+ + ". Current slot pool status: "
+ + getSlotServiceStatus());
Review comment:
Printing `acquiredResources` can actually produce quite some text. Hence, I am wondering whether we should really include this information in every `NoResourceAvailableException` since it will be logged for every request later on. Maybe it could be better to log it once in this method and then fail the requests w/o this information.
```
log.info("Could not acquire the minimum required resources. Failing all pending requests. Acquired {}. Current slot pool status: {}.", acquiredResources, getSlotServiceStatus());
```
What do you think @rkhachatryan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
}, {
"hash" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328",
"triggerID" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"triggerType" : "PUSH"
}, {
"hash" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351",
"triggerID" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61bd9db42a4990df50beca81555e1091eb880f2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #16457:
URL: https://github.com/apache/flink/pull/16457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r668494597
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -647,7 +647,10 @@ private ResourceCounter tryFulfillRequirementsWithPendingSlots(
pendingSlots = allocationResult.getNewAvailableResources();
if (!allocationResult.isSuccessfulAllocating()
&& sendNotEnoughResourceNotifications) {
- LOG.warn("Could not fulfill resource requirements of job {}.", jobId);
+ LOG.warn(
Review comment:
Unrelated to this PR: I am not sure whether not enough resource availability should be a warning because this is a normal condition in Flink and does not indicate a problem from Flink's perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r667874251
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -647,7 +647,12 @@ private ResourceCounter tryFulfillRequirementsWithPendingSlots(
pendingSlots = allocationResult.getNewAvailableResources();
if (!allocationResult.isSuccessfulAllocating()
&& sendNotEnoughResourceNotifications) {
- LOG.warn("Could not fulfill resource requirements of job {}.", jobId);
+ // TODO (review): free slots are logged as zero here, but non-zero in
+ // JobMaster.slotPoolService
Review comment:
I was concerned that it logs zero free slots - inconsistently with the other log statements from this PR.
In fact, it always logs zero free slots here, even right after returning them to `DefaultSlotTracker.freeSlots`.
I'm trying to understand what's going on there...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
}, {
"hash" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328",
"triggerID" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"triggerType" : "PUSH"
}, {
"hash" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 94ee2c10a64e7106de5d9dee069d5425bd77f030 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328)
* 61bd9db42a4990df50beca81555e1091eb880f2d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48113937331f9eaf9da6f16b70e7c86680eef30b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
}, {
"hash" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328",
"triggerID" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"triggerType" : "PUSH"
}, {
"hash" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351",
"triggerID" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"triggerType" : "PUSH"
}, {
"hash" : "43b9f912edc610a59c7a84ee549e5c2ff61b9dd9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43b9f912edc610a59c7a84ee549e5c2ff61b9dd9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61bd9db42a4990df50beca81555e1091eb880f2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351)
* 43b9f912edc610a59c7a84ee549e5c2ff61b9dd9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48113937331f9eaf9da6f16b70e7c86680eef30b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-879279068
Thanks for reviewing @tillrohrmann!
Merged into master as b1c5421a42c9e6bc5b16114fc75ccc7fb001c236.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877907367
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 43b9f912edc610a59c7a84ee549e5c2ff61b9dd9 (Thu Sep 23 18:03:16 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r668284397
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -647,7 +647,12 @@ private ResourceCounter tryFulfillRequirementsWithPendingSlots(
pendingSlots = allocationResult.getNewAvailableResources();
if (!allocationResult.isSuccessfulAllocating()
&& sendNotEnoughResourceNotifications) {
- LOG.warn("Could not fulfill resource requirements of job {}.", jobId);
+ // TODO (review): free slots are logged as zero here, but non-zero in
+ // JobMaster.slotPoolService
Review comment:
I see, I'll remove the TODO then.
Thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48113937331f9eaf9da6f16b70e7c86680eef30b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r669457129
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java
##########
@@ -348,14 +348,17 @@ public void notifyNotEnoughResourcesAvailable(
Collection<ResourceRequirement> acquiredResources) {
assertRunningInMainThread();
- failPendingRequests();
+ failPendingRequests(acquiredResources);
}
- private void failPendingRequests() {
+ private void failPendingRequests(Collection<ResourceRequirement> acquiredResources) {
if (!pendingRequests.isEmpty()) {
final NoResourceAvailableException cause =
new NoResourceAvailableException(
- "Could not acquire the minimum required resources.");
+ "Could not acquire the minimum required resources. Acquired: "
+ + acquiredResources
+ + ". Current slot pool status: "
+ + getSlotServiceStatus());
Review comment:
Opened #16457 after an offline discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16457: [hotfix][runtime] Log slot pool status if unable to fulfill job requirements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16457:
URL: https://github.com/apache/flink/pull/16457#issuecomment-877915805
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20292",
"triggerID" : "48113937331f9eaf9da6f16b70e7c86680eef30b",
"triggerType" : "PUSH"
}, {
"hash" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328",
"triggerID" : "94ee2c10a64e7106de5d9dee069d5425bd77f030",
"triggerType" : "PUSH"
}, {
"hash" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351",
"triggerID" : "61bd9db42a4990df50beca81555e1091eb880f2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 94ee2c10a64e7106de5d9dee069d5425bd77f030 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20328)
* 61bd9db42a4990df50beca81555e1091eb880f2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org