[GitHub] [superset] rusackas commented on issue #19073: PyPi: Picture urls are dead

[GitBox <gi...@apache.org>]

rusackas commented on issue #19073:
URL: https://github.com/apache/superset/issues/19073#issuecomment-1379601845

   Hmm... this seems to be because the images are using relative paths. This works fine for the readme on Github, but breaks on PyPi. I can make them absolute paths pointing to the file on `master` on GitHub, and it'll work (that's why the Superset logo works on PyPi). Downside is, as these PyPi versions age, I believe they'll always point to the image on `master` (whether it's there or not). This means the screenshots may not always be representative of the version on PyPi, and if the image URLs change on `master` we'll have a different problem.
   
   I'm not sure if that makes things better or worse.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org