You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/22 18:11:00 UTC
[GitHub] [incubator-nuttx] michallenc opened a new pull request #2588: St7789
michallenc opened a new pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588
## Summary
These commits add support for ST7789 controller based on ST7735 and following changes to boards/arm/imxrt/teensy-4.x to support ER-TFT1.14-1 over SPI on Teensy 4.x.
## Testing
Tested on Teensy-4.1 with ER-TFT1.14-1 display and framebuffer apps example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749781782
>
>
> > Hi @michallenc very nice contribution, it will be useful for LILYGO TTGO modules that uses the same LCD controller.
> > There is a compilation warning promoted to error: in the spiinfo() the %x is not accepting an uint32_t, it needs a %lx instead.
>
> Thanks @acassis. I should have run compilations with werror to pick this one.
On some compilers and some architectures, a uint32_t is a unsigned long, on others it may be an unsigned int. on 64 bit architectures, for example, uint32_t is an unsigned int and NOT a long. The only safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749742089
> Hi @michallenc very nice contribution, it will be useful for LILYGO TTGO modules that uses the same LCD controller.
> There is a compilation warning promoted to error: in the spiinfo() the %x is not accepting an uint32_t, it needs a %lx instead.
Thanks @acassis. I should have run compilations with werror to pick this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749731415
Hi @michallenc very nice contribution, it will be useful for LILYGO TTGO modules that uses the same LCD controller.
There is a compilation warning promoted to error: in the spiinfo() the %x is not accepting an uint32_t, it needs a %lx instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749786530
> One safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
I did that a lot, but the only truly standard and portable way to print a uint32_t is by using the standard format definitions as provided by intttypes.h, specifially PRIx32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749786530
> The only safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
I did that a lot, but the only truly standard and portable way to print a uint32_t is by using the standard format definitions as provided by intttype.h, specifially PRIx32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749786530
> The only safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
I did that a lot, but the only truly standard and portable way to print a uint32_t is by using the standard format definitions as provided by intttype.h
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749781782
>
>
> > Hi @michallenc very nice contribution, it will be useful for LILYGO TTGO modules that uses the same LCD controller.
> > There is a compilation warning promoted to error: in the spiinfo() the %x is not accepting an uint32_t, it needs a %lx instead.
>
> Thanks @acassis. I should have run compilations with werror to pick this one.
On some compilers and some architectures, a uint32_t is a unsigned long, on others it may be an unsigned int. on 64 bit architectures, for example, uint32_t could be an unsigned int rather than a long. It could be either a 32-bit ARM. One safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749781782
>
>
> > Hi @michallenc very nice contribution, it will be useful for LILYGO TTGO modules that uses the same LCD controller.
> > There is a compilation warning promoted to error: in the spiinfo() the %x is not accepting an uint32_t, it needs a %lx instead.
>
> Thanks @acassis. I should have run compilations with werror to pick this one.
On some compilers and some architectures, a uint32_t is a unsigned long, on others it may be an unsigned int. on 64 bit architectures, for example, uint32_t could be an unsigned int rather than a long. It could be either a 32-bit ARM. The only safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749786530
> The only safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
I did that a lot, but the only truly standard and portable way to print a uint32_t is by using the standard format definitions as provided by intttypes.h, specifially PRIx32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-750016855
> > The %x / %lx problem was in arch/arm/src/imxrt/imxrt_lpspi.c file, not in common drivers/ directory, so why are we worried about other architectures?
>
> Yes, that does make some difference. Still, using the definitions in intttypes.h is the recommended and stanard way to print al fixed width integers and is still recommended.
@patacongo Thanks for claryfying this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749837878
> The %x / %lx problem was in arch/arm/src/imxrt/imxrt_lpspi.c file, not in common drivers/ directory, so why are we worried about other architectures?
Yes, that does make some difference. Still, using the definitions in intttypes.h is the recommended and stanard way to print al fixed width integers and is still recommended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #2588: Support for ST7789 controller
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #2588:
URL: https://github.com/apache/incubator-nuttx/pull/2588#issuecomment-749811795
> > One safe and portable way to do this is with a cast: Use %lx then cast the argument to (unsigned long).
>
> I did that a lot, but the only truly standard and portable way to print a uint32_t is by using the standard format definitions as provided by intttypes.h, specifially PRIx32
@patacongo I am a bit confused here. The %x / %lx problem was in arch/arm/src/imxrt/imxrt_lpspi.c file, not in common drivers/ directory, so why are we worried about other architectures? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org