You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pa...@apache.org on 2018/05/17 23:34:31 UTC

[beam] branch master updated: Mention adding a reviewer in PR template. (#5397)

This is an automated email from the ASF dual-hosted git repository.

pabloem pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 31d7e95  Mention adding a reviewer in PR template. (#5397)
31d7e95 is described below

commit 31d7e951be728b5b2e6fb489fd27c16e875b58f1
Author: Pablo <pa...@users.noreply.github.com>
AuthorDate: Thu May 17 16:34:28 2018 -0700

    Mention adding a reviewer in PR template. (#5397)
    
    Simplifying PR template. Mention adding a reviewer.
---
 .github/PULL_REQUEST_TEMPLATE.md | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 0cf5002..00c270c 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,17 +1,10 @@
-DESCRIPTION HERE
+**Please** add a meaningful description for your change here
 
 ------------------------
 
 Follow this checklist to help us incorporate your contribution quickly and easily:
 
- - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
- - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- - [ ] Write a pull request description that is detailed enough to understand:
-   - [ ] What the pull request does
-   - [ ] Why it does it
-   - [ ] How it does it
-   - [ ] Why this approach
- - [ ] Each commit in the pull request should have a meaningful subject line and body.
- - [ ] Run `./gradlew build` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
 
+It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.

-- 
To stop receiving notification emails like this one, please contact
pabloem@apache.org.