[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170215#comment-17170215 ] 

ASF GitHub Bot commented on GEODE-7846:
---------------------------------------

gesterzhou commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464551192



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
##########
@@ -344,7 +344,12 @@ void incClearCount(LocalRegion lr) {
     if (lr != null && !(lr instanceof HARegion)) {
       CachePerfStats stats = lr.getCachePerfStats();
       if (stats != null) {
-        stats.incClearCount();
+        if (lr instanceof BucketRegion) {

Review comment:
       Usually we use:  if (owner.isUsedForPartitionedRegionBucket()) { instead. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Clear in Partitioned Region should have its own stats
> -----------------------------------------------------
>
>                 Key: GEODE-7846
>                 URL: https://issues.apache.org/jira/browse/GEODE-7846
>             Project: Geode
>          Issue Type: Improvement
>          Components: core
>            Reporter: Xiaojian Zhou
>            Priority: Major
>              Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats: 
> 1) clear operation executed. 
> 2) clear operation failed
> 3) clear messages sends to buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)