You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/07/25 10:58:13 UTC

[GitHub] [tinkerpop] dalaro commented on issue #1167: TINKERPOP-2271 Add warnings=true|false console preference (tp34)

dalaro commented on issue #1167: TINKERPOP-2271 Add warnings=true|false console preference (tp34)
URL: https://github.com/apache/tinkerpop/pull/1167#issuecomment-514999046
 
 
   Thanks for taking a look and giving guidance.  I just followed up on both of your points, amended the commit, and force-pushed.
   
   I tried to stick to the CHANGELOG file's established convention, so I added an Improvements subsection under 3.4.3 with a single bullet point listing the JIRA key and a one-liner description.
   
   I also updated the asciidoc's table of console prefs.  I couldn't identify a sort on that table, so I just inserted warnings after colors, the only other boolean-typed option.  Here's a link to how it looks on the PR now:
   
   https://github.com/apache/tinkerpop/blob/82de2a60fcff81643008e3b11f5fef358bc8808e/docs/src/reference/gremlin-applications.asciidoc#console-preferences

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services