You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/09/22 16:22:34 UTC

Re: Review Request 37996: WIP: Added property manager

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37996/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 4:22 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.


Changes
-------

Addresses reviewer's issues. Adds Adam as reviewer.


Bugs: MESOS-3231
    https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
-------

WIP

Introduces the `PathInheritedProperties` class which allows to create a tree where nodes can be tag with some property. This property is then inherited by children nodes.

Two behaviors are implemented, overriding, i.e. Adding a property to the child node of another node with a property already will result in the ancestor property being lost. The second behavior, accumulating, takes a function and accumulates
properties of all ancestors.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 76e1674e08bbe65a4fdf86731823a61f231d6d12 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/properties.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt baa648aacfd5204c33e102b58126862729fbb612 
  3rdparty/libprocess/3rdparty/stout/tests/properties_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37996/diff/


Testing
-------

make check


Thanks,

Alexander Rojas