You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "gudegg (GitHub)" <gi...@apache.org> on 2018/12/20 13:10:35 UTC
[GitHub] [incubator-dubbo] gudegg opened pull request #3031: Fix
active properties not working
## What is the purpose of the change
FIX Low priority configuration overrides high priority
https://github.com/apache/incubator-dubbo/issues/3014
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #3031: FIX Low
priority configuration overrides high priority
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
But this pr has no changes...
I can't merge one commit of your pull request.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] phqct commented on issue #3031: FIX Low
priority configuration overrides high priority
Posted by "phqct (GitHub)" <gi...@apache.org>.
你们是谁 怎么邮箱我一直有 这么多 ？？
________________________________
penghao0426@outlook.com
From: 时无两丶<ma...@github.com>
Date: 2018-12-21 10:21
To: apache/incubator-dubbo<ma...@noreply.github.com>
CC: Subscribed<ma...@noreply.github.com>
Subject: Re: [apache/incubator-dubbo] FIX Low priority configuration overrides high priority (#3031)
Seems nothing changed..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-dubbo/pull/3031#issuecomment-449218317>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AqChVHLeV9cwapjPxA4OvVCjG_D3-_5Lks5u7EW9gaJpZM4ZcKfU>.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] gudegg closed pull request #3031: FIX Low
priority configuration overrides high priority
Posted by "gudegg (GitHub)" <gi...@apache.org>.
[ pull request closed by gudegg ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] gudegg commented on issue #3031: FIX Low
priority configuration overrides high priority
Posted by "gudegg (GitHub)" <gi...@apache.org>.
@carryxyh see first commit https://github.com/apache/incubator-dubbo/pull/3031/commits/0868127f3fc520ee77e76dbda6400cd2d9baef46
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3031: FIX
Low priority configuration overrides high priority
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=h1) Report
> Merging [#3031](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/fae5fa83f27e287befb927652784b94bcd135a4c?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
+ Coverage 64.24% 64.31% +0.06%
==========================================
Files 584 584
Lines 26056 26056
Branches 4562 4562
==========================================
+ Hits 16740 16757 +17
+ Misses 7133 7118 -15
+ Partials 2183 2181 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | :arrow_down: |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `77.2% <0%> (-2.21%)` | :arrow_down: |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `63.79% <0%> (-1.73%)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `65.83% <0%> (-0.84%)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `67.78% <0%> (-0.68%)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.39% <0%> (+0.37%)` | :arrow_up: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.95% <0%> (+0.75%)` | :arrow_up: |
| [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `62.36% <0%> (+1.74%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `89.71% <0%> (+1.86%)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=footer). Last update [fae5fa8...ef74a05](https://codecov.io/gh/apache/incubator-dubbo/pull/3031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #3031: FIX Low
priority configuration overrides high priority
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Seems nothing changed..
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] gudegg commented on issue #3031: FIX Low
priority configuration overrides high priority
Posted by "gudegg (GitHub)" <gi...@apache.org>.
@carryxyh 我重新提交下吧
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] gudegg commented on issue #3031: FIX Low
priority configuration overrides high priority
Posted by "gudegg (GitHub)" <gi...@apache.org>.
@carryxyh 我看master 12-13已经有人改了
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3031 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org