You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "Jay Freeman (saurik)" <sa...@saurik.com> on 2002/03/16 20:38:04 UTC
[PATCH] apr_intialize() doesn't work on Win32
There were some Unix specific threading code added to apr_initialize() at
some point, and WIN32 wasn't listed in the non-Unix OS's list. Shouldn't
there be a UNIX define somewhere that can be used instead? (If need be,
provided by a generic APR header; so as to get the list of "non-Unix" into a
single location?)
Index: start.c
===================================================================
RCS file: /home/cvspublic/apr/misc/unix/start.c,v
retrieving revision 1.63
diff -u -r1.63 start.c
--- start.c 13 Mar 2002 20:39:23 -0000 1.63
+++ start.c 16 Mar 2002 19:37:24 -0000
@@ -83,7 +83,7 @@
return APR_SUCCESS;
}
-#if !defined(BEOS) && !defined(OS2)
+#if !defined(BEOS) && !defined(OS2) && !defined(WIN32)
apr_unix_setup_lock();
apr_proc_mutex_unix_setup_lock();
apr_unix_setup_time();
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
Re: [PATCH] apr_intialize() doesn't work on Win32
Posted by Jeff Trawick <tr...@attglobal.net>.
"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> At 01:46 PM 3/16/2002, you wrote:
> >DOH, I see what happened. A new win32 specific version was added. I
> >forgot I was using VC++ 7 (which doesn't read the dsp files anymore), and
> >had imported the project file (which meant I didn't get the new updates).
> >Sorry about that... on a now related note: any chance of keeping VC++ 7
> >projects in the repository? :)
>
> No, just at there is little chance of maintaining the current MSVC 6.0 projects
> the way things stand.
>
> The "only right way"(TM)(R) would be to create a perl project manager.
> Sure, I hear, let's not make those "poor [Windows|Netware|IDEfan] users"
> set up and configure perl, it's "too hard"(SM).
>
> Phoey.
so do we get to ditch awk some day?
--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...
Re: [PATCH] apr_intialize() doesn't work on Win32
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 01:46 PM 3/16/2002, you wrote:
>DOH, I see what happened. A new win32 specific version was added. I
>forgot I was using VC++ 7 (which doesn't read the dsp files anymore), and
>had imported the project file (which meant I didn't get the new updates).
>Sorry about that... on a now related note: any chance of keeping VC++ 7
>projects in the repository? :)
No, just at there is little chance of maintaining the current MSVC 6.0 projects
the way things stand.
The "only right way"(TM)(R) would be to create a perl project manager.
Sure, I hear, let's not make those "poor [Windows|Netware|IDEfan] users"
set up and configure perl, it's "too hard"(SM).
Phoey. That's the direction I'm heading in; autogenerating a workspace
schema from our existing Makefile.in sources. Take the top level definitions
from the Makefiles, and spit into a perl script the targets. Let the IDE
architecture-specific perl module craft it into a project schema and write
out build files.
This could be extended for VC5/6 .dsw/.dsp files, VC7 .msproj files, the
Netware CodeWarrior projects, the Apple's OSX IDE, and so on.
So requests to add more cruft that -someone- [probably not you] must
maintain will be rudely rejected. Offers to help create such a solution
will be warmly embraced :-)
Bill
Re: [PATCH] apr_intialize() doesn't work on Win32
Posted by "Jay Freeman (saurik)" <sa...@saurik.com>.
DOH, I see what happened. A new win32 specific version was added. I
forgot I was using VC++ 7 (which doesn't read the dsp files anymore), and
had imported the project file (which meant I didn't get the new updates).
Sorry about that... on a now related note: any chance of keeping VC++ 7
projects in the repository? :)
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
----- Original Message -----
From: "Jay Freeman (saurik)" <sa...@saurik.com>
To: "apr-dev" <de...@apr.apache.org>
Sent: Saturday, March 16, 2002 1:38 PM
Subject: [PATCH] apr_intialize() doesn't work on Win32
> There were some Unix specific threading code added to apr_initialize() at
> some point, and WIN32 wasn't listed in the non-Unix OS's list. Shouldn't
> there be a UNIX define somewhere that can be used instead? (If need be,
> provided by a generic APR header; so as to get the list of "non-Unix" into
a
> single location?)
>
...
>
> Sincerely,
> Jay Freeman (saurik)
> saurik@saurik.com
Re: [PATCH] apr_intialize() doesn't work on Win32
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 01:38 PM 3/16/2002, you wrote:
>There were some Unix specific threading code added to apr_initialize() at
>some point, and WIN32 wasn't listed in the non-Unix OS's list. Shouldn't
>there be a UNIX define somewhere that can be used instead? (If need be,
>provided by a generic APR header; so as to get the list of "non-Unix" into a
>single location?)
Win32 uses apr/misc/win32/start.c
Perhaps you meant the cygwin port?