You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/17 07:12:08 UTC
[GitHub] [incubator-inlong] wilburjiang0 opened a new pull request, #4691: [INLONG-3266] [Improve][Agent] Get local ip when ip in config is not present #3266
wilburjiang0 opened a new pull request, #4691:
URL: https://github.com/apache/incubator-inlong/pull/4691
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Fixes #3266
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] zk1510 commented on a diff in pull request #4691: [INLONG-3266][Agent] Get local IP when IP in config is not present
Posted by GitBox <gi...@apache.org>.
zk1510 commented on code in PR #4691:
URL: https://github.com/apache/incubator-inlong/pull/4691#discussion_r899853944
##########
inlong-agent/agent-common/src/test/java/org/apache/inlong/agent/common/TestAgentUtils.java:
##########
@@ -84,4 +84,9 @@ public void testTimeConvertToMillsec() {
Assert.assertEquals(1620374040000L, AgentUtils.timeStrConvertToMillSec("202105071554", "M"));
}
+ @Test
+ public void testFetchLocalIp() {
+ Assert.assertNotEquals("127.0.0.1",AgentUtils.fetchLocalIp());
Review Comment:
it's suggested to add a blank before the second parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4691: [INLONG-3266][Agent] Get local IP when IP in config is not present
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4691:
URL: https://github.com/apache/incubator-inlong/pull/4691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org