You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Dawid Weiss (Jira)" <ji...@apache.org> on 2021/12/17 18:13:00 UTC

[jira] [Resolved] (LUCENE-10285) gradle regenerate TLDs file / tokenizer dependency is backwards/wrong

     [ https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dawid Weiss resolved LUCENE-10285.
----------------------------------
    Fix Version/s: 10.0 (main)
       Resolution: Fixed

> gradle regenerate TLDs file / tokenizer dependency is backwards/wrong
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-10285
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10285
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Assignee: Dawid Weiss
>            Priority: Major
>             Fix For: 10.0 (main)
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> To reproduce: {{./gradlew regenerate --rerun-tasks}}
> You'll see this behavior:
> {noformat}
> > Task :lucene:analysis:common:generateUAX29URLEmailTokenizerInternal
> Regenerating UAX29URLEmailTokenizerImpl. This may take a long time (and requires 12g of memory!).
> Recompiling JFlex: lucene/analysis/common/src/java/org/apache/lucene/analysis/email/UAX29URLEmailTokenizerImpl.jflex
> ...
> > Task :lucene:analysis:common:generateTldsInternal
> Execution optimizations have been disabled for task ':lucene:analysis:common:generateTldsInternal' to ensure correctness due to the following reasons:
>   - Gradle detected a problem with the following location: '/home/rmuir/workspace/lucene/lucene/analysis/common/src/java/org/apache/lucene/analysis/email/ASCIITLD.jflex'. Reason: Task ':lucene:analysis:common:generateUAX29URLEmailTokenizerInternal' uses this output of task ':lucene:analysis:common:generateTldsInternal' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
> Found 1489 TLDs in IANA TLD Database at https://data.iana.org/TLD/tlds-alpha-by-domain.txt
>                       ASCIITLD: 1370 TLDs
>     ASCIITLDprefix_1CharSuffix:  108 TLDs
>     ASCIITLDprefix_2CharSuffix:   11 TLDs
>                          Total: 1489 TLDs
> You've regenerated the TLD include file, remember to regenerate UAX29URLEmailTokenizerImpl too.
> {noformat}
> So it regenerates the TLD include file after the UAX29URLEmailTokenizerImpl, which means now you gotta run "gradlew regenerate" again to really pick up the changes.
> cc [~dweiss]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org