You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/07/01 20:18:53 UTC
[GitHub] [commons-lang] orionlibs opened a new pull request, #1075: ArchUtils refactoring
orionlibs opened a new pull request, #1075:
URL: https://github.com/apache/commons-lang/pull/1075
The logic to get the Processor for a given architecture string is spread across the init_* methods. A cleaner design would be to have a separate private method that maps the architecture string to a Processor, and calls that from the init_* methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs closed pull request #1075: ArchUtils refactoring
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs closed pull request #1075: ArchUtils refactoring
URL: https://github.com/apache/commons-lang/pull/1075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] orionlibs commented on pull request #1075: ArchUtils refactoring
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #1075:
URL: https://github.com/apache/commons-lang/pull/1075#issuecomment-1616694182
@garydgregory thank you. So, should I close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1075: ArchUtils refactoring
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1075:
URL: https://github.com/apache/commons-lang/pull/1075#issuecomment-1616683936
@orionlibs Thank you for your PR.
-1: IMO, this is a case where you have to consider making it evident to people reading the code what it is we support. One method per processor type makes it obvious as soon as you look at the class. I would say that this is a rare case, where a tiny amount of code duplication (calling the ctor) is worth it because: The code is only invoked once (per class loader) and the method names serve as "code as documentation". Each private method _could_ have a Javadoc added to make it even nicer, but I'll leave that as a TODO for anyone that wants to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1075: ArchUtils refactoring
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1075:
URL: https://github.com/apache/commons-lang/pull/1075#issuecomment-1616727797
> @garydgregory thank you. So, should I close this PR?
I think so. You can check the master branch for the current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org