[GitHub] [nifi] turcsanyip commented on a diff in pull request #6580: NIFI-10693 Remove direct proxy configuration properties from PutBigQuery

[GitBox <gi...@apache.org>]

turcsanyip commented on code in PR #6580:
URL: https://github.com/apache/nifi/pull/6580#discussion_r1006066864


##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java:
##########
@@ -119,6 +127,15 @@ public class PutBigQuery extends AbstractBigQueryProcessor {
     private int recordBatchCount;
     private boolean skipInvalidRows;
 
+    public static final PropertyDescriptor PROJECT_ID = new PropertyDescriptor.Builder()
+        .name(PROJECT_ID_NAME)
+        .displayName("Project ID")
+        .description(PROJECT_ID_DESC)
+        .required(true)
+        .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+        .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+        .build();

Review Comment:
   It could be simplified:
   ```suggestion
       public static final PropertyDescriptor PROJECT_ID = new PropertyDescriptor.Builder()
               .fromPropertyDescriptor(AbstractBigQueryProcessor.PROJECT_ID)
               .required(true)
               .build();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org