You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/01/23 17:53:58 UTC
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16973
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
[tablet] OpDriver::ExecuteAsync() return void
This patch addresses a long standing TODO in OpDriver::ExecuteAsync(),
changing its signature to return void instead of Status.
This patch doesn't contain any functional modifications.
Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
---
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/op_driver.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/txn_participant-test.cc
5 files changed, 14 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/16973/1
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16973 )
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
Patch Set 1: Code-Review+2
LGTM. Not sure what's up with the unit tests, but it doesn't seem like it could be related.
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Jan 2021 00:46:10 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16973 )
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
Patch Set 1: Code-Review+1
LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 03:30:55 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16973 )
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
Patch Set 1:
> LGTM. Not sure what's up with the unit tests, but it doesn't seem
> like it could be related.
Thank you for review.
Yep, I looked at the failures and re-run those tests via dist-test, and didn't see failures. From the semantics of this patch and my recent verification it's clear those failures are unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:09:52 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16973 )
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
Patch Set 1: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:08:41 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] OpDriver::ExecuteAsync() return void
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16973 )
Change subject: [tablet] OpDriver::ExecuteAsync() return void
......................................................................
[tablet] OpDriver::ExecuteAsync() return void
This patch addresses a long standing TODO in OpDriver::ExecuteAsync(),
changing its signature to return void instead of Status.
This patch doesn't contain any functional modifications.
Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Reviewed-on: http://gerrit.cloudera.org:8080/16973
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/ops/op_driver.cc
M src/kudu/tablet/ops/op_driver.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/txn_participant-test.cc
5 files changed, 14 insertions(+), 16 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Mahesh Reddy: Looks good to me, but someone else must approve
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I459cdac9f17a6345b2508a6b7137c0768811dd87
Gerrit-Change-Number: 16973
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>