You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/03 07:01:38 UTC
Review Request 28635: CLOUDSTACK-8003: test_egress_fw_rules.py -
Remove test case dependency on each other and improve cleanup code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28635/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8003
https://issues.apache.org/jira/browse/CLOUDSTACK-8003
Repository: cloudstack-git
Description
-------
Test cases in this test suite use a common account and hence in cleanup operations, we explicitly delete all the resources created in a test case.
This adds to the running time of the test cases.
Also in case, there is any issue in cleanup operation, all other test cases will get affected.
Hence, it is wise to create a new account for each test cases and delete the account in cleanup.
Diffs
-----
test/integration/component/test_egress_fw_rules.py 4f95925
Diff: https://reviews.apache.org/r/28635/diff/
Testing
-------
Yes.
2 test cases failed because db info in my config was wrong.
Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
ok
Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName: test_01_egress_fr1 | Status : SUCCESS ===
ok
Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_1_egress_fr2 | Status : SUCCESS ===
ok
Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_egress_fr2 | Status : SUCCESS ===
ok
Test Communication blocked with network that is other than specified ... === TestName: test_03_1_egress_fr3 | Status : EXCEPTION ===
ERROR
Test Communication blocked with network that is other than specified ... === TestName: test_03_egress_fr3 | Status : SUCCESS ===
ok
Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : FAILED ===
FAIL
Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4 | Status : FAILED ===
FAIL
Test Create Egress rule and check the IP tables ... SKIP: Skip
Test Create Egress rule and check the IP tables ... SKIP: Skip
Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status : SUCCESS ===
ok
Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
ok
Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status : SUCCESS ===
ok
Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status : SUCCESS ===
ok
Test Port Forwarding and Egress Conflict ... SKIP: Skip
Test Port Forwarding and Egress Conflict ... SKIP: Skip
Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS ===
ok
Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS ===
ok
Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status : SUCCESS ===
ok
Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status : SUCCESS ===
ok
Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 | Status : EXCEPTION ===
ERROR
Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status : SUCCESS ===
ok
Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS ===
ok
Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : SUCCESS ===
ok
Test Redundant Router : Master failover ... === TestName: test_13_1_egress_fr13 | Status : SUCCESS ===
ok
Test Redundant Router : Master failover ... === TestName: test_13_egress_fr13 | Status : SUCCESS ===
ok
Thanks,
Gaurav Aradhye
Re: Review Request 28635: CLOUDSTACK-8003: test_egress_fw_rules.py -
Remove test case dependency on each other and improve cleanup code
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28635/#review63962
-----------------------------------------------------------
Gentle Reminder
- Gaurav Aradhye
On Dec. 3, 2014, 11:31 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28635/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 11:31 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8003
> https://issues.apache.org/jira/browse/CLOUDSTACK-8003
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Test cases in this test suite use a common account and hence in cleanup operations, we explicitly delete all the resources created in a test case.
>
> This adds to the running time of the test cases.
> Also in case, there is any issue in cleanup operation, all other test cases will get affected.
>
> Hence, it is wise to create a new account for each test cases and delete the account in cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 4f95925
>
> Diff: https://reviews.apache.org/r/28635/diff/
>
>
> Testing
> -------
>
> Yes.
>
> 2 test cases failed because db info in my config was wrong.
>
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
> Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName: test_01_egress_fr1 | Status : SUCCESS ===
> ok
> Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_1_egress_fr2 | Status : SUCCESS ===
> ok
> Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_egress_fr2 | Status : SUCCESS ===
> ok
> Test Communication blocked with network that is other than specified ... === TestName: test_03_1_egress_fr3 | Status : EXCEPTION ===
> ERROR
> Test Communication blocked with network that is other than specified ... === TestName: test_03_egress_fr3 | Status : SUCCESS ===
> ok
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : FAILED ===
> FAIL
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4 | Status : FAILED ===
> FAIL
> Test Create Egress rule and check the IP tables ... SKIP: Skip
> Test Create Egress rule and check the IP tables ... SKIP: Skip
> Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status : SUCCESS ===
> ok
> Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
> ok
> Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status : SUCCESS ===
> ok
> Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status : SUCCESS ===
> ok
> Test Port Forwarding and Egress Conflict ... SKIP: Skip
> Test Port Forwarding and Egress Conflict ... SKIP: Skip
> Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS ===
> ok
> Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS ===
> ok
> Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status : SUCCESS ===
> ok
> Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status : SUCCESS ===
> ok
> Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 | Status : EXCEPTION ===
> ERROR
> Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status : SUCCESS ===
> ok
> Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS ===
> ok
> Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : SUCCESS ===
> ok
> Test Redundant Router : Master failover ... === TestName: test_13_1_egress_fr13 | Status : SUCCESS ===
> ok
> Test Redundant Router : Master failover ... === TestName: test_13_egress_fr13 | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 28635: CLOUDSTACK-8003: test_egress_fw_rules.py -
Remove test case dependency on each other and improve cleanup code
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28635/#review63968
-----------------------------------------------------------
Ship it!
pushed to master fe0a55fb5747b2343e83d30990737aa48f78b57d and 4.5 a6fd3190c0942aaf75a1e64e6eea1b39eba74105
- SrikanteswaraRao Talluri
On Dec. 3, 2014, 6:01 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28635/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 6:01 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8003
> https://issues.apache.org/jira/browse/CLOUDSTACK-8003
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Test cases in this test suite use a common account and hence in cleanup operations, we explicitly delete all the resources created in a test case.
>
> This adds to the running time of the test cases.
> Also in case, there is any issue in cleanup operation, all other test cases will get affected.
>
> Hence, it is wise to create a new account for each test cases and delete the account in cleanup.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 4f95925
>
> Diff: https://reviews.apache.org/r/28635/diff/
>
>
> Testing
> -------
>
> Yes.
>
> 2 test cases failed because db info in my config was wrong.
>
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
> Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName: test_01_egress_fr1 | Status : SUCCESS ===
> ok
> Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_1_egress_fr2 | Status : SUCCESS ===
> ok
> Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_egress_fr2 | Status : SUCCESS ===
> ok
> Test Communication blocked with network that is other than specified ... === TestName: test_03_1_egress_fr3 | Status : EXCEPTION ===
> ERROR
> Test Communication blocked with network that is other than specified ... === TestName: test_03_egress_fr3 | Status : SUCCESS ===
> ok
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : FAILED ===
> FAIL
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4 | Status : FAILED ===
> FAIL
> Test Create Egress rule and check the IP tables ... SKIP: Skip
> Test Create Egress rule and check the IP tables ... SKIP: Skip
> Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status : SUCCESS ===
> ok
> Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
> ok
> Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status : SUCCESS ===
> ok
> Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status : SUCCESS ===
> ok
> Test Port Forwarding and Egress Conflict ... SKIP: Skip
> Test Port Forwarding and Egress Conflict ... SKIP: Skip
> Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS ===
> ok
> Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS ===
> ok
> Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status : SUCCESS ===
> ok
> Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status : SUCCESS ===
> ok
> Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 | Status : EXCEPTION ===
> ERROR
> Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status : SUCCESS ===
> ok
> Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS ===
> ok
> Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : SUCCESS ===
> ok
> Test Redundant Router : Master failover ... === TestName: test_13_1_egress_fr13 | Status : SUCCESS ===
> ok
> Test Redundant Router : Master failover ... === TestName: test_13_egress_fr13 | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Gaurav Aradhye
>
>