[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1171: feat: add config for log cleaner

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #1171:
URL: https://github.com/apache/incubator-kvrocks/pull/1171#discussion_r1044285449


##########
kvrocks.conf:
##########
@@ -97,6 +97,16 @@ dir /tmp/kvrocks
 #
 log-dir stdout
 
+# You can configure log-retention-days to control whether to enable the log cleaner
+# and the maximum retention days that the INFO level logs will be kept.
+#
+# if set to -1, that means to disable the log cleaner.
+# if set to 0, all previous INFO level logs will be immediately removed.

Review Comment:
   I read we use the same config for all logs. How can logs in other levels have different manner?



##########
kvrocks.conf:
##########
@@ -97,6 +97,16 @@ dir /tmp/kvrocks
 #
 log-dir stdout
 
+# You can configure log-retention-days to control whether to enable the log cleaner
+# and the maximum retention days that the INFO level logs will be kept.
+#
+# if set to -1, that means to disable the log cleaner.
+# if set to 0, all previous INFO level logs will be immediately removed.

Review Comment:
   I read we use the same config for all logs. How can logs in other levels have different manners?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org