You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Michael Wyraz (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 15:30:40 UTC
[jira] [Created] (TAP5-1761) Codestyle: Please use protected for
methods and variables in service classes
Codestyle: Please use protected for methods and variables in service classes
----------------------------------------------------------------------------
Key: TAP5-1761
URL: https://issues.apache.org/jira/browse/TAP5-1761
Project: Tapestry 5
Issue Type: Improvement
Affects Versions: 5.3
Reporter: Michael Wyraz
Most service classes use "private" for instance variables, and methods. This makes it almost impossible to extend them.
Example:
- TAP5-1148
Other example:
I decorated ComponentClassResolver to convert PageNames to page-names in URLs which is more seo friendly. Almost everything worked except events because there's a fixed pattern in ComponentEventLinkEncoderImpl.
There's no way to decorate/extend this class to change the behaviour of this pattern or the decodeComponentEventLinkRequest because one would need access to all those private things to override the method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1761) Codestyle: Please use protected for
methods and variables in service classes
Posted by "Igor Drobiazko (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko closed TAP5-1761.
--------------------------------
Resolution: Won't Fix
Sorry, but we wan't fix that. The service implementations are part of the internal API and subject to change.
> Codestyle: Please use protected for methods and variables in service classes
> ----------------------------------------------------------------------------
>
> Key: TAP5-1761
> URL: https://issues.apache.org/jira/browse/TAP5-1761
> Project: Tapestry 5
> Issue Type: Improvement
> Affects Versions: 5.3
> Reporter: Michael Wyraz
>
> Most service classes use "private" for instance variables, and methods. This makes it almost impossible to extend them.
> Example:
> - TAP5-1148
> Other example:
> I decorated ComponentClassResolver to convert PageNames to page-names in URLs which is more seo friendly. Almost everything worked except events because there's a fixed pattern in ComponentEventLinkEncoderImpl.
> There's no way to decorate/extend this class to change the behaviour of this pattern or the decodeComponentEventLinkRequest because one would need access to all those private things to override the method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1761) Codestyle: Please use protected for
methods and variables in service classes
Posted by "Igor Drobiazko (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Drobiazko closed TAP5-1761.
--------------------------------
Resolution: Won't Fix
Sorry, but we wan't fix that. The service implementations are part of the internal API and subject to change.
> Codestyle: Please use protected for methods and variables in service classes
> ----------------------------------------------------------------------------
>
> Key: TAP5-1761
> URL: https://issues.apache.org/jira/browse/TAP5-1761
> Project: Tapestry 5
> Issue Type: Improvement
> Affects Versions: 5.3
> Reporter: Michael Wyraz
>
> Most service classes use "private" for instance variables, and methods. This makes it almost impossible to extend them.
> Example:
> - TAP5-1148
> Other example:
> I decorated ComponentClassResolver to convert PageNames to page-names in URLs which is more seo friendly. Almost everything worked except events because there's a fixed pattern in ComponentEventLinkEncoderImpl.
> There's no way to decorate/extend this class to change the behaviour of this pattern or the decodeComponentEventLinkRequest because one would need access to all those private things to override the method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira