You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by nn...@apache.org on 2015/03/24 01:26:04 UTC
mesos git commit: Cleaned up TODO comments that are already
implemented.
Repository: mesos
Updated Branches:
refs/heads/master 1d5d6d690 -> 274e0768d
Cleaned up TODO comments that are already implemented.
No functional changes, comments removed only.
Review: https://reviews.apache.org/r/31637
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/274e0768
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/274e0768
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/274e0768
Branch: refs/heads/master
Commit: 274e0768d1f29406054608680caad344ba268599
Parents: 1d5d6d6
Author: Aaron Bell <aa...@gmail.com>
Authored: Mon Mar 23 16:52:58 2015 -0700
Committer: Niklas Q. Nielsen <ni...@mesosphere.io>
Committed: Mon Mar 23 16:52:58 2015 -0700
----------------------------------------------------------------------
include/mesos/mesos.proto | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/274e0768/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index ec8efae..faa56cc 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -135,11 +135,12 @@ message FrameworkInfo {
/**
* Describes a health check for a task or executor (or any arbitrary
* process/command). A "strategy" is picked by specifying one of the
- * optional fields, currently only 'http' and 'command' are
- * supported. Specifying more than one strategy is an error.
+ * optional fields; currently only 'command' is supported.
+ * Specifying more than one strategy is an error.
*/
message HealthCheck {
- // Describes an HTTP health check.
+ // Describes an HTTP health check. This is not fully implemented and not
+ // recommended for use - see MESOS-2533.
message HTTP {
// Port to send the HTTP request.
required uint32 port = 1;
@@ -159,6 +160,7 @@ message HealthCheck {
// for specific data in the response.
}
+ // HTTP health check - not yet recommended for use, see MESOS-2533.
optional HTTP http = 1;
// TODO(benh): Consider adding a URL health check strategy which
@@ -166,12 +168,7 @@ message HealthCheck {
// encapsulates all the details in a single string field.
// TODO(benh): Other possible health check strategies could include
- // one for TCP/UDP or a "command". A "command" could be running a
- // (shell) command to check the healthiness. We'd need to determine
- // what arguments (or environment variables) we'd want to set so
- // that the command could do it's job (i.e., do we want to expose
- // the stdout/stderr and/or the pid to make checking for healthiness
- // easier).
+ // one for TCP/UDP.
// Amount of time to wait until starting the health checks.
optional double delay_seconds = 2 [default = 15.0];