[GitHub] [cloudstack] rhtyd commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs
URL: https://github.com/apache/cloudstack/pull/3894#discussion_r382396997
 
 

 ##########
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##########
 @@ -2680,6 +2680,9 @@ public void buildACLSearchParameters(Account caller, Long id, String accountName
                         }
                     } else {
                         domainIdRecursiveListProject.third(Project.ListProjectResourcesCriteria.ListProjectResourcesOnly);
+                        if (listAll) {
 
 Review comment:
   @Pearl1594 can you add a check here that listall is true and the user is an admin (not a domain admin, not a user but an admin) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services