You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/06/05 09:35:57 UTC

[GitHub] [kylin] codecov-io commented on issue #675: Minor, remove duplicate code

codecov-io commented on issue #675: Minor, remove duplicate code
URL: https://github.com/apache/kylin/pull/675#issuecomment-499011979
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=h1) Report
   > Merging [#675](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c3a71101286ba994dec85aa515236b28c98b9e94?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/675/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #675      +/-   ##
   ============================================
   + Coverage     25.77%   25.78%   +<.01%     
   - Complexity     6008     6009       +1     
   ============================================
     Files          1382     1382              
     Lines         82201    82200       -1     
     Branches      11518    11518              
   ============================================
   + Hits          21190    21193       +3     
   + Misses        58962    58959       -3     
   + Partials       2049     2048       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/kylin/source/kafka/hadoop/KafkaFlatTableJob.java](https://codecov.io/gh/apache/kylin/pull/675/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvaGFkb29wL0thZmthRmxhdFRhYmxlSm9iLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/675/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (+0.3%)` | `7% <0%> (ø)` | :arrow_down: |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/675/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=footer). Last update [c3a7110...558dad9](https://codecov.io/gh/apache/kylin/pull/675?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services