[jira] [Commented] (CONNECTORS-533) Standard release image build binaries do not include dist/connector-lib-proprietary/jcifs-README.txt

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONNECTORS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460443#comment-13460443 ] 

Karl Wright commented on CONNECTORS-533:
----------------------------------------

A possible fix is to always create an xxx-README.txt file, AND create an xxx-PLACEHOLDER.txt file if there is a missing jar.  Then, at image time, we can filter out both .jar files and *-PLACEHOLDER.txt files.

This fix is simple enough that I think it is worth pulling up to the ManifoldCF 1.0 release.

                
> Standard release image build binaries do not include dist/connector-lib-proprietary/jcifs-README.txt
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CONNECTORS-533
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-533
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: ManifoldCF 1.0
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 1.0
>
>
> The release build downloads jcifs.jar, as it should, and then proceeds to build the jcifs connector.  Then, it creates the dist/connector-lib-proprietary directory as it should, having the jcifs.jar in it rather than the jcifs-README.txt.  When the release binary image is made, it excludes all jars from dist/connector-lib-proprietary, also as it is supposed to - but then there is no jcifs-README.txt left for the user to notice.
> There are two options here.  First option is create a stub for jcifs.jar, and then take steps to not download jcifs jar during the image build.  Second option is to create jcifs-README.txt regardless of whether jcifs.jar is present.  Unfortunately, the build logic currently may use the existence of the jcifs-README file to decided whether to enable the connector in the connectors-proprietary.xml file, so this may be tricky.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira