[GitHub] [beam] kennknowles commented on a change in pull request #14990: [BEAM-4767] Remove release script lines to replace container version

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #14990:
URL: https://github.com/apache/beam/pull/14990#discussion_r649570125



##########
File path: release/src/main/scripts/set_version.sh
##########
@@ -76,9 +76,6 @@ if [[ -z "$IS_SNAPSHOT_VERSION" ]] ; then
   sed -i -e "s/^__version__ = .*/__version__ = '${TARGET_VERSION}'/" sdks/python/apache_beam/version.py
   sed -i -e "s/sdk_version=.*/sdk_version=$TARGET_VERSION/" gradle.properties
   sed -i -e "s/SdkVersion = .*/SdkVersion = \"$TARGET_VERSION\"/" sdks/go/pkg/beam/core/core.go
-  # TODO: [BEAM-4767]
-  sed -i -e "s/'dataflow.fnapi_container_version' : .*/'dataflow.fnapi_container_version' : '${TARGET_VERSION}'/" runners/google-cloud-dataflow-java/build.gradle
-  sed -i -e "s/'dataflow.legacy_container_version' : .*/'dataflow.legacy_container_version' : 'beam-${TARGET_VERSION}'/" runners/google-cloud-dataflow-java/build.gradle

Review comment:
       In this code branch, the version is being set for building an RC tag, right? This line still used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org