You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2026/02/23 13:27:25 UTC
[PR] Exclude Jetty from Polaris Server [polaris]
snazy opened a new pull request, #3865:
URL: https://github.com/apache/polaris/pull/3865
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2842894451
##########
extensions/federation/hadoop/build.gradle.kts:
##########
@@ -44,6 +44,7 @@ dependencies {
exclude("com.sun.jersey", "jersey-server")
exclude("com.sun.jersey", "jersey-servlet")
exclude("io.dropwizard.metrics", "metrics-core")
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
+1 to remove comment from code and add rational to the PR description
##########
extensions/federation/hadoop/build.gradle.kts:
##########
@@ -44,6 +44,7 @@ dependencies {
exclude("com.sun.jersey", "jersey-server")
exclude("com.sun.jersey", "jersey-servlet")
exclude("io.dropwizard.metrics", "metrics-core")
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
+1 to remove comment from code and add rationale to the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2842852831
##########
extensions/federation/hadoop/build.gradle.kts:
##########
@@ -44,6 +44,7 @@ dependencies {
exclude("com.sun.jersey", "jersey-server")
exclude("com.sun.jersey", "jersey-servlet")
exclude("io.dropwizard.metrics", "metrics-core")
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
I’m fine either removing the comment entirely or expanding it to clearly explain the rationale, whichever we think adds more clarity for future readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2842894451
##########
extensions/federation/hadoop/build.gradle.kts:
##########
@@ -44,6 +44,7 @@ dependencies {
exclude("com.sun.jersey", "jersey-server")
exclude("com.sun.jersey", "jersey-servlet")
exclude("io.dropwizard.metrics", "metrics-core")
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
+1 to remove comment from code and add rationale to the PR description (commit message)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #3865:
URL: https://github.com/apache/polaris/pull/3865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2842547929
##########
extensions/federation/hadoop/build.gradle.kts:
##########
@@ -44,6 +44,7 @@ dependencies {
exclude("com.sun.jersey", "jersey-server")
exclude("com.sun.jersey", "jersey-servlet")
exclude("io.dropwizard.metrics", "metrics-core")
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
can you please add more descriptive comment (if required), i understand the intent and totally agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2840997240
##########
runtime/server/build.gradle.kts:
##########
@@ -43,7 +43,9 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
- runtimeOnly(project(":polaris-extensions-federation-hadoop"))
+ runtimeOnly(project(":polaris-extensions-federation-hadoop")) {
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
Shouldn't this exclusion go into the federation-hadoop build file? E.g.
```kotlin
// Hadoop dependencies (for Hadoop catalog support)
implementation(libs.hadoop.common) {
exclude("org.slf4j", "slf4j-reload4j")
...
exclude(group = "org.eclipse.jetty")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3865:
URL: https://github.com/apache/polaris/pull/3865#issuecomment-3944798201
This is a prerequisite for #3864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2842918933
##########
extensions/federation/hadoop/build.gradle.kts:
##########
@@ -44,6 +44,7 @@ dependencies {
exclude("com.sun.jersey", "jersey-server")
exclude("com.sun.jersey", "jersey-servlet")
exclude("io.dropwizard.metrics", "metrics-core")
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
Btw, would it be possible to add the rationale of removal to the PR description, so that reviewers or any other readers can understand the motivation better, which is also align with the Polaris PR template format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exclude Jetty from Polaris Server [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #3865:
URL: https://github.com/apache/polaris/pull/3865#discussion_r2841633298
##########
runtime/server/build.gradle.kts:
##########
@@ -43,7 +43,9 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
- runtimeOnly(project(":polaris-extensions-federation-hadoop"))
+ runtimeOnly(project(":polaris-extensions-federation-hadoop")) {
+ exclude(group = "org.eclipse.jetty") // No Jetty server, please
Review Comment:
works as well, yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org