You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/02/08 23:15:27 UTC

[jira] Created: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Remove recursive call in FetchOperator.getNextRow
-------------------------------------------------

                 Key: HIVE-1141
                 URL: https://issues.apache.org/jira/browse/HIVE-1141
             Project: Hadoop Hive
          Issue Type: Bug
    Affects Versions: 0.5.0, 0.6.0
            Reporter: Zheng Shao
            Assignee: Zheng Shao


There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
We should remove that recursive call.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831166#action_12831166 ] 

He Yongqiang commented on HIVE-1141:
------------------------------------

will test now.

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1141:
-----------------------------

    Attachment: HIVE-1141.1.patch
                HIVE-1141.1.branch-0.5.patch

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1141:
-------------------------------

      Resolution: Fixed
    Release Note: Remove recursive call in FetchOperator.getNextRow
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed to trunk and branch-0.5. Thanks Zheng!

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1141:
---------------------------------

    Affects Version/s:     (was: 0.5.0)
                           (was: 0.6.0)

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.5.0
>
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831182#action_12831182 ] 

He Yongqiang commented on HIVE-1141:
------------------------------------

Discussed with Zheng, this kind of recursive call will occur if all the files to fetch are empty.

+1, will commit after test pass.

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-1141:
-----------------------------

    Status: Patch Available  (was: Open)

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831173#action_12831173 ] 

He Yongqiang commented on HIVE-1141:
------------------------------------

Zheng, does your change work with CombineFileInputFormat?

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.5.0, 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1141) Remove recursive call in FetchOperator.getNextRow

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-1141:
---------------------------------

    Fix Version/s: 0.5.0
      Component/s: Query Processor

> Remove recursive call in FetchOperator.getNextRow
> -------------------------------------------------
>
>                 Key: HIVE-1141
>                 URL: https://issues.apache.org/jira/browse/HIVE-1141
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.5.0
>
>         Attachments: HIVE-1141.1.branch-0.5.patch, HIVE-1141.1.patch
>
>
> There is an unnecessary recursive getNextRow() call that caused stack overflow in some queries.
> We should remove that recursive call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.