You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by zr...@apache.org on 2022/05/11 23:02:12 UTC

[trafficcontrol] branch master updated: Remove unnecessary t3c debug logging (#6824)

This is an automated email from the ASF dual-hosted git repository.

zrhoffman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new a0325ec635 Remove unnecessary t3c debug logging (#6824)
a0325ec635 is described below

commit a0325ec63549839755e52c7cd983ce6d6c848e0b
Author: Rawlin Peters <ra...@apache.org>
AuthorDate: Wed May 11 17:02:07 2022 -0600

    Remove unnecessary t3c debug logging (#6824)
    
    Additionally, remove an unused method that was only being used by the
    unnecessary debug logging.
---
 cache-config/t3c-apply/t3c-apply.go           |  3 ---
 cache-config/t3c-apply/torequest/torequest.go | 16 ----------------
 2 files changed, 19 deletions(-)

diff --git a/cache-config/t3c-apply/t3c-apply.go b/cache-config/t3c-apply/t3c-apply.go
index 5a3edcbadf..ca06e0bf43 100644
--- a/cache-config/t3c-apply/t3c-apply.go
+++ b/cache-config/t3c-apply/t3c-apply.go
@@ -151,9 +151,6 @@ func Main() int {
 		return ExitCodeUserCheckError
 	}
 
-	toolName := trops.GetHeaderComment()
-	log.Debugf("toolname: %s\n", toolName)
-
 	// if running in Revalidate mode, check to see if it's
 	// necessary to continue
 	if cfg.Files == t3cutil.ApplyFilesFlagReval {
diff --git a/cache-config/t3c-apply/torequest/torequest.go b/cache-config/t3c-apply/torequest/torequest.go
index 4dbadfa144..7a107d7c9b 100644
--- a/cache-config/t3c-apply/torequest/torequest.go
+++ b/cache-config/t3c-apply/torequest/torequest.go
@@ -673,22 +673,6 @@ func (r *TrafficOpsReq) PrintWarnings() {
 	log.Infoln("======== End warning summary ========")
 }
 
-// GetHeaderComment looks up the tm.toolname parameter from traffic ops.
-func (r *TrafficOpsReq) GetHeaderComment() string {
-	result, err := getSystemInfo(r.Cfg)
-	if err != nil {
-		log.Errorln("getting system info: " + err.Error())
-		return "" // failing to get the toolname is an error, but not fatal
-	}
-	toolName := result["tm.toolname"]
-	if toolName, ok := toolName.(string); ok {
-		log.Infof("Found tm.toolname: %v\n", toolName)
-		return toolName
-	}
-	log.Errorln("Did not find tm.toolname!")
-	return "" // not having a tm.toolname Parameter is an error, but not fatal
-}
-
 // CheckRevalidateState retrieves and returns the revalidate status from Traffic Ops.
 func (r *TrafficOpsReq) CheckRevalidateState(sleepOverride bool) (UpdateStatus, error) {
 	log.Infoln("Checking revalidate state.")